Use *nix paths for database seed paths #69
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP on Windows has no trouble reading *nix file paths, but *nix cannot read Windows paths. Always use *nix paths in PHP.
|
I'm not a PHP developer but this seems like a very good PR. But I'd strongly suggest to remove all the whitespace changes from where you didn't touch the code. I actually couldn't find the actual change when I scrolled through diff. |
|
#64 seems related. |
|
My mistake, it looks like this was fixed in 7cd486b, but not tagged to a release. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP on Windows has no trouble reading *nix file paths, but *nix cannot
read Windows paths. Always use *nix paths in PHP.