Implement Code actions with autofix #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperAuguste
approved these changes
Sep 25, 2022
IntegratedQuantum
added a commit
to IntegratedQuantum/zls
that referenced
this pull request
Sep 28, 2022
…tools#673). The previous implementation always assumed spaces for indentation. But in stage2 code may contain tabs for indentation as well.
SuperAuguste
pushed a commit
that referenced
this pull request
Oct 13, 2022
* Allow tabs for the indentation added by the code actions feature (#673). The previous implementation always assumed spaces for indentation. But in stage2 code may contain tabs for indentation as well. * Fix some edge cases, properly detect indentation(any amount of spaces) and move the indentation code inside `createDiscardText()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds code actions that fix
unused variableandpointless discarderrors.There is also a new config option called
enable_autofix(off by default) which as name may indicate will automatically fix these errors when you save your file. This is essentially the same as Andrew's--autofixziglang/zig#12803.Autofix in action
Just save your file and all the work is done for you.
I've tested this feature on VS Code and Sublime Text 4. Autofix for the helix editor is currently blocked on helix-editor/helix#3957