-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove all Philips Hue lighting related quirks #993
Conversation
Pull Request Test Coverage Report for Build 1125150225
💛 - Coveralls |
Codecov Report
@@ Coverage Diff @@
## dev #993 +/- ##
==========================================
- Coverage 82.55% 82.23% -0.32%
==========================================
Files 189 182 -7
Lines 4798 4712 -86
==========================================
- Hits 3961 3875 -86
Misses 837 837
Continue to review full report at Codecov.
|
Do i need to re-pair my lights for this to take effect? |
No. You just need to be on Home Assistant 2021.9.0 or later. There are some minor differences (different manufacturer clusters, Signify instead of Philips as the manufacturer name, ...) when re-pairing lights (after having applied firmware updates) but the core functionality of the bulb always works. |
Thanks!
|
Requires zigpy/zigpy#788(MERGED)--> released in zigpy 0.37.0 (https://github.com/zigpy/zigpy/releases/tag/0.37.0)
All Philips Hue related lighting quirks are redundant, since zigpy/zigpy#788 was merged.
The "custom" attributes for Hue lights are part of ZCLv7 spec and are now always implemented.
Current (custom) attributes for Hue lighting quirks:
zha-device-handlers/zhaquirks/philips/__init__.py
Lines 93 to 111 in 8c61c6d
Background of why it's a good idea to get all Philips Hue lighting related quirks removed:
Newer Hue firmware (Koenkk/zigbee-OTA#47) changes the signatures of Hue lights.
For the older (ZLL profile) lights, it looks like only the manufacturer name changed.
For the newer (ZHA profile/Bluetooth) lights, it looks like cluster 64514/0xfc02 changed to 64515/0xfc03. (This may only be visible after re-pairing the light).
As the Hue quirks are not needed anymore since zigpy/zigpy#774 and zigpy/zigpy#788, as the attributes are directly implemented in zigpy, this PR would remove all lighting related quirks.
Tested and working with zigpy/zigpy#788.