Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BatterySize enum #3752

Merged
merged 4 commits into from
Jan 24, 2025
Merged

Conversation

tr4nt0r
Copy link
Contributor

@tr4nt0r tr4nt0r commented Jan 22, 2025

Proposed change

Sets correct battery size and voltage for _TZE200_pay2byax TS0601

Fixes #3713

Additional information

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.40%. Comparing base (4f64c18) to head (59b4fe1).
Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3752      +/-   ##
==========================================
+ Coverage   90.13%   90.40%   +0.26%     
==========================================
  Files         320      320              
  Lines       10473    10490      +17     
==========================================
+ Hits         9440     9483      +43     
+ Misses       1033     1007      -26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zhaquirks/tuya/ts0601_sensor.py Outdated Show resolved Hide resolved
@tr4nt0r tr4nt0r force-pushed the _TZE200_pay2byax_battery_size branch from 44d2323 to a9cad24 Compare January 23, 2025 01:24
@tr4nt0r tr4nt0r force-pushed the _TZE200_pay2byax_battery_size branch from a9cad24 to 3acf637 Compare January 23, 2025 18:12
@tr4nt0r tr4nt0r force-pushed the _TZE200_pay2byax_battery_size branch from 2614229 to 6405d78 Compare January 23, 2025 19:21
@tr4nt0r
Copy link
Contributor Author

tr4nt0r commented Jan 23, 2025

@TheJulianJES so I updated everything now. I think the PR now needs a new name 😂

@TheJulianJES TheJulianJES added the needs review This PR should be reviewed soon, as it generally looks good. label Jan 23, 2025
@TheJulianJES TheJulianJES changed the title Set battery size for Tuya _TZE200_pay2byax Add BatterySize enum Jan 23, 2025
@TheJulianJES TheJulianJES requested a review from Copilot January 24, 2025 03:01

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 12 out of 27 changed files in this pull request and generated no comments.

Files not reviewed (15)
  • zhaquirks/tuya/tuya_valve.py: Evaluated as low risk
  • zhaquirks/tuya/tuya_gas.py: Evaluated as low risk
  • zhaquirks/tuya/tuya_siren.py: Evaluated as low risk
  • zhaquirks/tuya/init.py: Evaluated as low risk
  • zhaquirks/xiaomi/aqara/magnet_ac01.py: Evaluated as low risk
  • zhaquirks/xiaomi/aqara/magnet_acn001.py: Evaluated as low risk
  • zhaquirks/xiaomi/aqara/magnet_agl02.py: Evaluated as low risk
  • zhaquirks/xiaomi/aqara/cube_aqgl01.py: Evaluated as low risk
  • tests/test_tuya_builder.py: Evaluated as low risk
  • zhaquirks/xiaomi/aqara/magnet_aq2.py: Evaluated as low risk
  • zhaquirks/xiaomi/aqara/cube.py: Evaluated as low risk
  • zhaquirks/tuya/tuya_sensor.py: Evaluated as low risk
  • tests/test_xiaomi.py: Evaluated as low risk
  • zhaquirks/xiaomi/aqara/motion_acn001.py: Evaluated as low risk
  • zhaquirks/xiaomi/aqara/motion_agl02.py: Evaluated as low risk
Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@TheJulianJES TheJulianJES merged commit d9481d3 into zigpy:dev Jan 24, 2025
9 checks passed
@tr4nt0r tr4nt0r deleted the _TZE200_pay2byax_battery_size branch January 24, 2025 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review This PR should be reviewed soon, as it generally looks good.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Device Support Request] _TZE200_pay2byax
4 participants