Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2 empty lines between v2 quirk definitions #3742

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

TheJulianJES
Copy link
Collaborator

Proposed change

This adds two empty lines between each v2 quirk definition when there are multiple in a single file.

Additional information

This was done inconsistently before and pre-commit/ruff doesn't enforce this, since we don't create a new class here or anything. So, this PR just adds them manually to existing files.

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.12%. Comparing base (c82ffed) to head (6d99e84).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3742   +/-   ##
=======================================
  Coverage   90.12%   90.12%           
=======================================
  Files         320      320           
  Lines       10466    10466           
=======================================
  Hits         9433     9433           
  Misses       1033     1033           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheJulianJES TheJulianJES added the code quality Improvement to code quality label Jan 21, 2025
@TheJulianJES TheJulianJES merged commit eaa46ac into zigpy:dev Jan 23, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Improvement to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant