Fix missing endpoints for Aqara H1 wireless remotes #3674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheJulianJES
added
bugfix
The device sometimes doesn't report these endpoints as available, so quirks v2 code that `adds` or `replaces` clusters on those endpoints will cause ZHA to break. Zigpy now allows us to add these endpoints to the zigpy device, so we can also add clusters to the endpoints in the same quirk without issues.
TheJulianJES
force-pushed
the
tjj/fix_aqara_h1_remotes_endpoints_v2_quirks
branch
from
59e4ba3 to
3a661f4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3674 +/- ##
=======================================
Coverage 89.85% 89.85%
=======================================
Files 322 322
Lines 10379 10380 +1
=======================================
+ Hits 9326 9327 +1
Misses 1053 1053 ☔ View full report in Codecov by Sentry. |
|
Is there a way to update zha directly or do we need for HA Core to update? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Fix missing endpoints for Aqara H1 wireless remotes.
The device sometimes doesn't report these endpoints as available, so quirks v2 code that
addsorreplacesclusters on those endpoints will cause ZHA to break.Zigpy now allows us to add these endpoints to the zigpy device, so we can also add clusters to the endpoints in the same quirk without issues.
Additional information
Addresses home-assistant/core#134686 and home-assistant/core#134691.
Follow-up to #3564
This needs zigpy/zigpy#1524 and a corresponding zigpy bump, then a rebase before tests will pass.(done)Checklist
pre-commitchecks pass / the code has been formatted using Black