-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Nedis ZBSC30WT sensor _TZE200_s1xgth2u
variant
#3634
Add Nedis ZBSC30WT sensor _TZE200_s1xgth2u
variant
#3634
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3634 +/- ##
=======================================
Coverage 89.84% 89.84%
=======================================
Files 322 322
Lines 10371 10371
=======================================
Hits 9318 9318
Misses 1053 1053 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
For tests, just add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
great. merge at will... |
_TZE200_s1xgth2u
variant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Proposed change
Add support for new device.
Additional information
I have the device and added the same change as a custom quirk.
Requesting help wrt unit tests.
Fixes #3073
Checklist
pre-commit
checks pass / the code has been formatted using Black