Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nedis ZBSC30WT sensor _TZE200_s1xgth2u variant #3634

Merged
merged 3 commits into from
Dec 26, 2024

Conversation

bangert
Copy link
Contributor

@bangert bangert commented Dec 24, 2024

Proposed change

Add support for new device.

Additional information

I have the device and added the same change as a custom quirk.
Requesting help wrt unit tests.
Fixes #3073

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.84%. Comparing base (56001dd) to head (ee7fc47).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3634   +/-   ##
=======================================
  Coverage   89.84%   89.84%           
=======================================
  Files         322      322           
  Lines       10371    10371           
=======================================
  Hits         9318     9318           
  Misses       1053     1053           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@prairiesnpr prairiesnpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@prairiesnpr
Copy link
Contributor

For tests, just add ("_TZE200_s1xgth2u", "TS0601", 100, 10) to test_handle_get_data in tests/test_tuya_sensor.py.

@bangert bangert requested a review from prairiesnpr December 25, 2024 10:10
Copy link
Contributor

@prairiesnpr prairiesnpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@bangert
Copy link
Contributor Author

bangert commented Dec 25, 2024

great. merge at will...

@TheJulianJES TheJulianJES added the Tuya Request/PR regarding a Tuya device label Dec 26, 2024
@TheJulianJES TheJulianJES changed the title add quirk for Nedis ZBSC30WT (#3073) Add Nedis ZBSC30WT sensor _TZE200_s1xgth2u variant Dec 26, 2024
Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TheJulianJES TheJulianJES merged commit 16cf752 into zigpy:dev Dec 26, 2024
9 checks passed
@bangert bangert deleted the add_support_for_nedis_zbsc30wt branch December 28, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tuya Request/PR regarding a Tuya device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Device Support Request] TS0601 by _TZE200_s1xgth2u for Nedis SmartLife Zigbee Climate Sensor ZBSC30WT
3 participants