Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Schneider outlet quirk to schneiderelectric #3586

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

atsju
Copy link
Contributor

@atsju atsju commented Dec 6, 2024

Proposed change

Simple move of file to keep things clean
closes #3577

Additional information

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

@atsju atsju marked this pull request as draft December 6, 2024 18:58
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.79%. Comparing base (97413e3) to head (7414d90).
Report is 4 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3586      +/-   ##
==========================================
- Coverage   89.79%   89.79%   -0.01%     
==========================================
  Files         323      322       -1     
  Lines       10414    10413       -1     
==========================================
- Hits         9351     9350       -1     
  Misses       1063     1063              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atsju
Copy link
Contributor Author

atsju commented Dec 6, 2024

@kosmiq @TheJulianJES @dmulcahey
You participated in initial development, please have a look.

I made code changes that I think have low risk but I'm completely new here and don't have device for test

@atsju atsju marked this pull request as ready for review December 6, 2024 19:08
@TheJulianJES TheJulianJES added the code quality Improvement to code quality label Dec 7, 2024
@TheJulianJES TheJulianJES changed the title move file from schneider folder to schneiderelectric Move Schneider outlet quirk to schneiderelectric Dec 7, 2024
Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good.

@TheJulianJES TheJulianJES added the ready PR should be ready to merge label Dec 9, 2024
@TheJulianJES TheJulianJES merged commit 3bc841a into zigpy:dev Dec 9, 2024
9 checks passed
@atsju atsju deleted the JST/issue3577 branch December 10, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Improvement to code quality ready PR should be ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move zhaquirks/schneider to zhaquirks/schneiderelectric
2 participants