Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tuya RoyalGardineer valve water consumed value #3558

Merged

Conversation

mrrstux
Copy link
Contributor

@mrrstux mrrstux commented Nov 27, 2024

Proposed change

Converts RoyalGardineer valve water consumed value from deciliters to liters.

Additional information

Changes TuyaQuirkBuilder.tuya_meterig API to allow custom value scale.

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.88%. Comparing base (979551d) to head (50b4cfe).
Report is 7 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3558      +/-   ##
==========================================
+ Coverage   89.85%   89.88%   +0.02%     
==========================================
  Files         321      322       +1     
  Lines       10374    10404      +30     
==========================================
+ Hits         9322     9352      +30     
  Misses       1052     1052              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheJulianJES TheJulianJES added the Tuya Request/PR regarding a Tuya device label Nov 28, 2024
@mrrstux mrrstux force-pushed the royal-gardineer-valve-quirk-value-converter branch from 92a20f7 to 7ce801a Compare December 3, 2024 20:14
@mrrstux mrrstux marked this pull request as ready for review December 3, 2024 20:16
@mrrstux mrrstux force-pushed the royal-gardineer-valve-quirk-value-converter branch from 7ce801a to 94fb7b7 Compare December 16, 2024 17:41
@TheJulianJES TheJulianJES changed the title RoyalGardineer valve water consumed value converter Fix Tuya RoyalGardineer valve water consumed value Dec 22, 2024
Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks!

@TheJulianJES TheJulianJES added the v2 quirk Quirks using v2 API. Might add custom entities that need translation keys in HA. label Dec 22, 2024
@TheJulianJES TheJulianJES merged commit d116e37 into zigpy:dev Dec 22, 2024
9 checks passed
@mrrstux mrrstux deleted the royal-gardineer-valve-quirk-value-converter branch December 23, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tuya Request/PR regarding a Tuya device v2 quirk Quirks using v2 API. Might add custom entities that need translation keys in HA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants