-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Tuya RoyalGardineer valve water consumed value #3558
Merged
TheJulianJES
merged 4 commits into
zigpy:dev
from
mrrstux:royal-gardineer-valve-quirk-value-converter
Dec 22, 2024
Merged
Fix Tuya RoyalGardineer valve water consumed value #3558
TheJulianJES
merged 4 commits into
zigpy:dev
from
mrrstux:royal-gardineer-valve-quirk-value-converter
Dec 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3558 +/- ##
==========================================
+ Coverage 89.85% 89.88% +0.02%
==========================================
Files 321 322 +1
Lines 10374 10404 +30
==========================================
+ Hits 9322 9352 +30
Misses 1052 1052 ☔ View full report in Codecov by Sentry. |
prairiesnpr
reviewed
Nov 27, 2024
mrrstux
force-pushed
the
royal-gardineer-valve-quirk-value-converter
branch
from
December 3, 2024 20:14
92a20f7
to
7ce801a
Compare
Convert RoyalGardineer valve water consumed value from deciliters to liters.
mrrstux
force-pushed
the
royal-gardineer-valve-quirk-value-converter
branch
from
December 16, 2024 17:41
7ce801a
to
94fb7b7
Compare
TheJulianJES
changed the title
RoyalGardineer valve water consumed value converter
Fix Tuya RoyalGardineer valve water consumed value
Dec 22, 2024
TheJulianJES
approved these changes
Dec 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, thanks!
TheJulianJES
added
the
v2 quirk
Quirks using v2 API. Might add custom entities that need translation keys in HA.
label
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Converts RoyalGardineer valve water consumed value from deciliters to liters.
Additional information
Changes TuyaQuirkBuilder.tuya_meterig API to allow custom value scale.
Checklist
pre-commit
checks pass / the code has been formatted using Black