Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ZLinky variant for firmware v14.0 #3448

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

blauret
Copy link
Contributor

@blauret blauret commented Oct 21, 2024

Proposed change

Add Signature for the latest Firmware release of the ZLinky_TIC

Additional information

The latest firmware add new clusters which prevent it from being associated with the quirks and result in incorrect data being pushed in HA.

Fixes #3365

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.40%. Comparing base (c788758) to head (e782ba4).
Report is 3 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3448   +/-   ##
=======================================
  Coverage   89.39%   89.40%           
=======================================
  Files         309      309           
  Lines       10006    10014    +8     
=======================================
+ Hits         8945     8953    +8     
  Misses       1061     1061           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
I really prefer having a full signature and replacement for each class for (slightly) better readability.
However, we should just convert this to a v2 quirk. Something like this might already just work:

(
    QuirkBuilder(manufacturer, model)
    .replaces(ZLinkyTICManufacturerCluster)
    .add_to_registry()
)

There are some other examples in the repo.

I'll merge this for now, but it would be amazing if you can convert it to a v2 quirk in the future.

@TheJulianJES TheJulianJES changed the title #3365 ZLinky Modified signature for Firmware v14.0 Add ZLinky variant for firmware v14.0 Oct 23, 2024
@TheJulianJES TheJulianJES merged commit de3643c into zigpy:dev Oct 23, 2024
9 checks passed
@blauret
Copy link
Contributor Author

blauret commented Oct 23, 2024

Thanks! I really prefer having a full signature and replacement for each class for (slightly) better readability. However, we should just convert this to a v2 quirk. Something like this might already just work:

(
    QuirkBuilder(manufacturer, model)
    .replaces(ZLinkyTICManufacturerCluster)
    .add_to_registry()
)

There are some other examples in the repo.

I'll merge this for now, but it would be amazing if you can convert it to a v2 quirk in the future.

It’s the plan. I will give it a try. I spent some time to look at the quirk v2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Lixee Zlinky_TIC v14
2 participants