Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AttributeDefs for quirks subclassed from TuyaMCUCluster and TuyaNewManufCluster #3441

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

prairiesnpr
Copy link
Contributor

@prairiesnpr prairiesnpr commented Oct 18, 2024

Proposed change

Converts from attributes to AttributeDefs on quirks subclassed from TuyaMCUCluster and TuyaNewManufCluster.

Required by changes introduced in #3417

Additional information

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.40%. Comparing base (51c2062) to head (f5b7804).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3441      +/-   ##
==========================================
+ Coverage   89.36%   89.40%   +0.03%     
==========================================
  Files         308      308              
  Lines        9985    10021      +36     
==========================================
+ Hits         8923     8959      +36     
  Misses       1062     1062              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheJulianJES TheJulianJES added the Tuya Request/PR regarding a Tuya device label Oct 18, 2024
Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They all look good to me. Thanks!

@TheJulianJES TheJulianJES merged commit 6d029ef into zigpy:dev Oct 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tuya Request/PR regarding a Tuya device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants