Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Philips Hue remotes initial attribute writes #3435

Merged

Conversation

TheJulianJES
Copy link
Collaborator

@TheJulianJES TheJulianJES commented Oct 16, 2024

Untested

These changes are still untested.

Proposed change

This fix ensures the attr_config is correctly written on the PhilipsBasicCluster when the device is paired or reconfigured.
The bind() method on the Basic cluster isn't actually called, as ZHA doesn't bind the Basic cluster anymore.

Additional information

The following PR should be merged first (so it's applied to clusters that inherit from PhilipsBasicCluster) (this PR might need a rebase afterwards):

We should also figure out what the "philips" 0x0031 attribute actually does.
It seems like there are no issues at the moment, even though we're not writing that attribute.
Maybe it's enough to bind the manufacturer specific Philips remote cluster (which we're doing in ZHA)?

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.43%. Comparing base (f50a2de) to head (c2fd099).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3435      +/-   ##
==========================================
+ Coverage   89.41%   89.43%   +0.01%     
==========================================
  Files         309      309              
  Lines       10027    10025       -2     
==========================================
  Hits         8966     8966              
+ Misses       1061     1059       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This fix ensures the `attr_config` is correctly written on the `PhilipsBasicCluster` when the device is paired or reconfigured.
The `bind()` method on the `Basic` cluster isn't actually called, as ZHA doesn't bind the `Basic` cluster anymore.
@TheJulianJES TheJulianJES force-pushed the tjj/fix_philips_remote_attr_write branch from 8e217f5 to 031d19f Compare October 16, 2024 03:17
@TheJulianJES TheJulianJES marked this pull request as ready for review October 26, 2024 00:55
@TheJulianJES TheJulianJES merged commit 43e9ea9 into zigpy:dev Oct 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant