Fix Philips Hue remotes initial attribute writes #3435
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Untested
These changes are still untested.
Proposed change
This fix ensures the
attr_config
is correctly written on thePhilipsBasicCluster
when the device is paired or reconfigured.The
bind()
method on theBasic
cluster isn't actually called, as ZHA doesn't bind theBasic
cluster anymore.Additional information
The following PR should be merged first (so it's applied to clusters that inherit from
PhilipsBasicCluster
) (this PR might need a rebase afterwards):AttributeDefs
forPhilipsBasicCluster
#3434We should also figure out what the "philips"
0x0031
attribute actually does.It seems like there are no issues at the moment, even though we're not writing that attribute.
Maybe it's enough to bind the manufacturer specific Philips remote cluster (which we're doing in ZHA)?
Checklist
pre-commit
checks pass / the code has been formatted using Black