Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tuya air sensor _TZE204_dwcarsat variant #3429

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Conversation

AndyDorn
Copy link
Contributor

Proposed change

Simple fix for #3337 to add support for additional manufacturer signature info "_TZE204_dwcarsat" for model "TS0601" tuya smart air

Additional information

"Fixes #3337".

Checklist

Put an 'x' in all boxes that apply.
Note: You do not need to tick all boxes before creating a PR.

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.71%. Comparing base (fa734ad) to head (148270e).
Report is 8 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3429   +/-   ##
=======================================
  Coverage   88.71%   88.71%           
=======================================
  Files         306      306           
  Lines        9820     9820           
=======================================
  Hits         8712     8712           
  Misses       1108     1108           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheJulianJES TheJulianJES added the Tuya Request/PR regarding a Tuya device label Oct 16, 2024
@TheJulianJES TheJulianJES changed the title Adds support for additional signature model Add Tuya air sensor _TZE204_dwcarsat variant Oct 16, 2024
Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TheJulianJES TheJulianJES merged commit 93af47a into zigpy:dev Oct 16, 2024
7 checks passed
@WeterPeter
Copy link

WeterPeter commented Dec 21, 2024

It seems the values of
sensor.tze204_ts0601_smart_air_house_keeper_concentratie_formaldehyde
and
sensor.tze204_ts0601_smart_air_house_keeper_kooldioxide
from the _TZE204_dwcarsat are switched?

Is this indeed the case and if so can this be fixed in this quirk?

Screenshot 2024-12-21 at 13 50 15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tuya Request/PR regarding a Tuya device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Device Support Request] TS0601 by _TZE204_dwcarsat Smart Air quality sensor (Zigbee)
3 participants