Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tuya _TZE204_sooucan5 presence and illumination variant #3363

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

deadman96385
Copy link
Contributor

@deadman96385 deadman96385 commented Sep 14, 2024

Proposed change

Add support for Tuya VXZBRB58 which is a circular presence and illumination sensor.

Additional information

ZHA detects them but provides no entities, this change makes them be detected properly

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Sep 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.49%. Comparing base (acecf70) to head (d35a11e).
Report is 18 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3363   +/-   ##
=======================================
  Coverage   88.49%   88.49%           
=======================================
  Files         305      305           
  Lines        9621     9621           
=======================================
  Hits         8514     8514           
  Misses       1107     1107           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheJulianJES TheJulianJES added the Tuya Request/PR regarding a Tuya device label Sep 16, 2024
@deadman96385
Copy link
Contributor Author

@TheJulianJES Is there something more I need to do to get his merged?

Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, all good. I did have a look at Z2M and the sensor is listed as a different model there, as some settings are different, but I guess if this fully works as expected, it's fine.

@TheJulianJES TheJulianJES changed the title Add Tuya _TZE204_sooucan5 presence and illumination variant Add Tuya _TZE204_sooucan5 presence and illumination variant Oct 12, 2024
@TheJulianJES TheJulianJES merged commit fa734ad into zigpy:dev Oct 12, 2024
7 checks passed
@TheJulianJES
Copy link
Collaborator

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tuya Request/PR regarding a Tuya device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants