Add initial Sonoff smart water valve quirk

[fgsch]

Proposed change

Add quirk for Sonoff SWV.

Additional information

This exposes the water_valve_state attribute in the custom cluster and adds a sensor to HA with the same information.
EDIT: The enum sensor will not be added with this initial PR. We'd like two get two different binary sensors to parse the same attribute. Since quirks v2 can't do this yet, we'll need to do this work in a future PR.
This initial PR will just expose the attribute.

Checklist

• The changes are tested and work correctly
• pre-commit checks pass / the code has been formatted using Black
• Tests have been added to verify that the new code works

[codecov]

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.67%. Comparing base (213ce10) to head (0438e95).
Report is 3 commits behind head on dev.

Files with missing lines	Patch %	Lines
zhaquirks/sonoff/swv.py	94.11%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##              dev    #3346   +/-   ##
=======================================
  Coverage   89.67%   89.67%           
=======================================
  Files         316      317    +1     
  Lines       10281    10298   +17     
=======================================
+ Hits         9219     9235   +16     
- Misses       1062     1063    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[TheJulianJES]

Would two separate binary sensors make more sense for this? (instead of an enum sensor)
We can't really parse it this via v2 quirks (yet), so just wondering.

[nicknol]

I would vote for 2 binary sensors. This would make it more convenient for triggers and alerts.

[TheJulianJES]

zigpy/zha#305 and zigpy/zha#303 would be required for this.

[fgsch]

@TheJulianJES what about the approach in #3340 to have 2 binary sensors?

[TheJulianJES]

It would work, but we're creating "fake" attributes there, which isn't optimal.

[fgsch]

@TheJulianJES While the work is being decided, can we get this without the enum so at least people can fiddle with the attributes directly using e.g. zha toolkit?

Or you reckon zigpy/zha#305 and zigpy/zha#303 would be handled relatively soon?

[TheJulianJES]

Let's temporarily remove the quirks v2 enum sensor then. We should be able to get the quirk in the HA Core 2024.12 beta for tomorrow then.
Not sure on the timeline of the "attribute converters" yet. I hope we can get to it soon, but no promises.

[fgsch]

Awesome, thank you!

[TheJulianJES]

Thanks for the PR!
I've removed the quirks v2 enum sensor for now. We should be able to get the quirk in the HA Core 2024.12 beta for tomorrow then.

Hopefully, we get to add the "attribute converters" for quirks v2 relatively soon, so we can also add the binary sensor entities for HA.