Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Philips Hue wall switch RDM004 variant #3075

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

aradar
Copy link
Contributor

@aradar aradar commented Mar 28, 2024

Proposed change

This PR adds support for a newer revision of the wall switch from philips (identifier RDM004). This change is based on a few posts that I found that add support for this newer version via a custom quirk that is just a copy of the old version with a changed MODEL_INFO field in the signature [1][2]

So far, I have not tested this change on my home assistant setup, but this is the next step on my agenda for today :).

Additional information

Fixes #2764

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.22%. Comparing base (d84d94f) to head (1702bb8).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3075   +/-   ##
=======================================
  Coverage   89.22%   89.22%           
=======================================
  Files         307      307           
  Lines        9870     9870           
=======================================
  Hits         8807     8807           
  Misses       1063     1063           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NicolasDuran
Copy link

Works for me on 2024.7.3

@jonicious
Copy link

Works for me as well on 2024.8.3

@AM5800
Copy link

AM5800 commented Sep 10, 2024

My HA is crash-looping with this =(
Any tips for debugging? I have added this to configuration.yaml:

zha:
  enable_quirks: true
  custom_quirks_path: /config/zha_quirks

And I also put wallswitch.py into aforementioned /config/zha_quirks

The problem is: I am not getting any error messages at all. HA just dies.

P.S. I am using Home Assistant OS

@storm1er
Copy link

storm1er commented Oct 5, 2024

Working on 2024.10.1

@AM5800 using HAOS I had to do this instead:

zha:
  enable_quirks: true
  custom_quirks_path: config/zha_quirks # no leading /

@jpsen5
Copy link

jpsen5 commented Oct 16, 2024

@dmulcahey any chance you can review this for a potential merge? Thanks in advance!

@TheJulianJES
Copy link
Collaborator

We didn't forget about this PR. We want to merge #2340 first, as it's quite a huge change.

@jpsen5
Copy link

jpsen5 commented Oct 16, 2024

@TheJulianJES thanks for the update!

@TheJulianJES TheJulianJES force-pushed the feature/add_ROM004_support branch from ed518bf to fe64adb Compare October 16, 2024 02:43
@TheJulianJES TheJulianJES changed the title Add support for the RDM004 wall switch from philips Add Philips Hue wall switch RDM004 variant Oct 16, 2024
Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I've rebased it to work with the changes from the big PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Device Support Request] Add support for Philips Hue Wall Switch RDM004
7 participants