-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Philips Hue wall switch RDM004
variant
#3075
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3075 +/- ##
=======================================
Coverage 89.22% 89.22%
=======================================
Files 307 307
Lines 9870 9870
=======================================
Hits 8807 8807
Misses 1063 1063 ☔ View full report in Codecov by Sentry. |
Works for me on 2024.7.3 |
Works for me as well on 2024.8.3 |
My HA is crash-looping with this =(
And I also put The problem is: I am not getting any error messages at all. HA just dies. P.S. I am using Home Assistant OS |
Working on 2024.10.1 @AM5800 using HAOS I had to do this instead: zha:
enable_quirks: true
custom_quirks_path: config/zha_quirks # no leading / |
@dmulcahey any chance you can review this for a potential merge? Thanks in advance! |
We didn't forget about this PR. We want to merge #2340 first, as it's quite a huge change. |
@TheJulianJES thanks for the update! |
ed518bf
to
fe64adb
Compare
RDM004
variant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I've rebased it to work with the changes from the big PR.
Proposed change
This PR adds support for a newer revision of the wall switch from philips (identifier RDM004). This change is based on a few posts that I found that add support for this newer version via a custom quirk that is just a copy of the old version with a changed
MODEL_INFO
field in the signature [1][2]So far, I have not tested this change on my home assistant setup, but this is the next step on my agenda for today :).
Additional information
Fixes #2764
Checklist
pre-commit
checks pass / the code has been formatted using Black