-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add power configuration cluster to ZLinky_TIC (requires firmware v12.0+) #1962
Add power configuration cluster to ZLinky_TIC (requires firmware v12.0+) #1962
Conversation
36cd28f
to
0d6133e
Compare
Pull Request Test Coverage Report for Build 3558665835
💛 - Coveralls |
Codecov ReportBase: 83.16% // Head: 83.17% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev #1962 +/- ##
=======================================
Coverage 83.16% 83.17%
=======================================
Files 248 248
Lines 7816 7820 +4
=======================================
+ Hits 6500 6504 +4
Misses 1316 1316
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Marked as draft again as the new cluster is supposed to be discoverable: fairecasoimeme/Zlinky_TIC#140 (comment) |
Make one new device class with the new EP/Cluster setting and it shall working OK. |
Thanks!
Is the signature cached somewhere? |
Looks like the cached in clusters information may come from this table:
|
Dont forget reversing the original device class then that firmware for it dont have power config cluster. All devices is saved in the One good example is updating one old IKEA controller or light that was released with ZLL firmware and getting one Zigbee 3 firmware can working OK but some devices must being deleted and rejoined for working OK. I think to be on the safe side is to recommending deleting the device after OTA update and waiting one minute (ZHA must doing the DB work finished) and doing one new joining of the device so the cluster setting is being OK. |
Was about to open an issue in zigpy, but looks like this was already discussed here: zigpy/zigpy#912 (comment) |
By the way nice IEEE of your device :-)))) |
I redacted it :) |
976433f
to
938c6a6
Compare
I've added a ZLinky_TIC_FW_V12 quirk with power configuration cluster so that both pre-v12 and post-v12 versions are supported:
|
…ture for ZLinky_TIC with firmware v12.0+
938c6a6
to
1ad7c3f
Compare
If changing the model info in the V12 firmware its being OK and i think it one good way to see that the device is running the updated version but normally it shall being enough reading the software version on the basic cluster for getting that. |
…ster's model attribute
For reference:
Marked as draft as I'm unsure how this affects devices with pre-v12.0 firmware.