Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xbee: Code refactoring #1919

Merged
merged 6 commits into from
Nov 19, 2022
Merged

Conversation

Shulyaka
Copy link
Contributor

@Shulyaka Shulyaka commented Nov 11, 2022

A little refactoring: make cluster classes non-internal for clarity and move types to a separate file.

@Shulyaka Shulyaka force-pushed the xbee_update_on_is_response branch from 60b6a0f to dd4f5a3 Compare November 11, 2022 23:41
@coveralls
Copy link

coveralls commented Nov 11, 2022

Pull Request Test Coverage Report for Build 3460741905

  • 141 of 152 (92.76%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 82.759%

Changes Missing Coverage Covered Lines Changed/Added Lines %
zhaquirks/xbee/init.py 47 50 94.0%
zhaquirks/xbee/types.py 86 94 91.49%
Totals Coverage Status
Change from base Build 3446076419: 0.07%
Covered Lines: 6336
Relevant Lines: 7656

💛 - Coveralls

@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2022

Codecov Report

Base: 82.68% // Head: 82.76% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (9964386) compared to base (59c098d).
Patch coverage: 92.94% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1919      +/-   ##
==========================================
+ Coverage   82.68%   82.76%   +0.08%     
==========================================
  Files         245      246       +1     
  Lines        7647     7660      +13     
==========================================
+ Hits         6323     6340      +17     
+ Misses       1324     1320       -4     
Impacted Files Coverage Δ
zhaquirks/xbee/types.py 91.48% <91.48%> (ø)
zhaquirks/xbee/__init__.py 95.04% <94.44%> (+1.76%) ⬆️
zhaquirks/xbee/xbee3_io.py 100.00% <100.00%> (ø)
zhaquirks/xbee/xbee_io.py 100.00% <100.00%> (+33.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Shulyaka
Copy link
Contributor Author

Shulyaka commented Nov 14, 2022

Ok, I've decided to separate the refactoring and the new functionality into two separate PRs.
This PR is for the refactoring only, no new functionality.

@Shulyaka Shulyaka force-pushed the xbee_update_on_is_response branch from 9964386 to f3a7f39 Compare November 14, 2022 10:48
@Shulyaka Shulyaka changed the title Xbee: Update input pins on IS command response Xbee: Code refactoring Nov 14, 2022
@dmulcahey dmulcahey merged commit 02fde22 into zigpy:dev Nov 19, 2022
@Shulyaka Shulyaka deleted the xbee_update_on_is_response branch November 19, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants