Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to Moes TRV TV02 #1843

Merged
merged 2 commits into from
Oct 21, 2022
Merged

Add support to Moes TRV TV02 #1843

merged 2 commits into from
Oct 21, 2022

Conversation

matlar83
Copy link
Contributor

@matlar83 matlar83 commented Oct 19, 2022 •
edited
Loading

Added the model in MODELS_INFO signature to apply the quirk also to Moes TV02 TRV

Fixes: #1839

@coveralls
Copy link

coveralls commented Oct 19, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3282722014

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.444%
Totals Coverage Status
Change from base Build 3268024177: 0.0%
Covered Lines: 6018
Relevant Lines: 7481
💛 - Coveralls

@matlar83 matlar83 mentioned this pull request Oct 19, 2022
Closed
javicalle
javicalle approved these changes Oct 19, 2022
View reviewed changes
Copy link
Collaborator

@javicalle javicalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@javicalle javicalle added the needs final review PR is ready for a final review from a maintainer label Oct 19, 2022
@javicalle
Copy link
Collaborator

Thanks matlar83, but can you edit your first comment and add the comment there?

Thanks in advanced.

MattWestb
MattWestb approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@MattWestb MattWestb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "ZONNSMART" TRVs also need presets added in ZHA for getting them working OK.
Add the the device after the last one in this code and you shall getting the right presents in the climate card in HA.

https://github.com/home-assistant/core/blob/d78c2a31a1eb4e945a5fa64a38a11ba7569e41ff/homeassistant/components/zha/climate.py#L761-L771

Testing if its working OK and making one linked PR in HA and all that we can getting from this TRVs is working OK in HA.

@javicalle
Copy link
Collaborator

Ouuuuch!
Always forget about this part 🤦🏻‍♂️

@matlar83
Copy link
Contributor Author

The "ZONNSMART" TRVs also need presets added in ZHA for getting them working OK. Add the the device after the last one in this code and you shall getting the right presents in the climate card in HA.

https://github.com/home-assistant/core/blob/d78c2a31a1eb4e945a5fa64a38a11ba7569e41ff/homeassistant/components/zha/climate.py#L761-L771

Testing if its working OK and making one linked PR in HA and all that we can getting from this TRVs is working OK in HA.

Hi,
I'm not sure how can I test it. Should I make the chnage in my HA instance first? How?

@dmulcahey dmulcahey merged commit 28f3399 into zigpy:dev Oct 21, 2022
javicalle added a commit to javicalle/home-assistant that referenced this pull request Oct 21, 2022
@javicalle
Add _TZE200_kds0pmmv to ZONNSMARTThermostat
4d71ca2 
Related to: zigpy/zha-device-handlers#1843
@javicalle javicalle mentioned this pull request Oct 21, 2022
Merged
19 tasks
@javicalle
Copy link
Collaborator

Thanks David.

Adminiuga pushed a commit to home-assistant/core that referenced this pull request Oct 21, 2022
@javicalle
Add _TZE200_kds0pmmv to ZHA ZONNSMARTThermostat (#80746)
b8c574e 
Add `_TZE200_kds0pmmv` to `ZONNSMARTThermostat`

Related to: zigpy/zha-device-handlers#1843
Djelibeybi pushed a commit to Djelibeybi/home-assistant-core that referenced this pull request Oct 24, 2022
@javicalle @Djelibeybi
Add _TZE200_kds0pmmv to ZHA ZONNSMARTThermostat (home-assistant#8…
f2c90c9 
…0746)

Add `_TZE200_kds0pmmv` to `ZONNSMARTThermostat`

Related to: zigpy/zha-device-handlers#1843
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattWestb MattWestb MattWestb approved these changes

@javicalle javicalle javicalle approved these changes

@dmulcahey dmulcahey dmulcahey approved these changes

Assignees
No one assigned
Labels
needs final review PR is ready for a final review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Device Support Request] MOES TRV TV02 (TS0601 - _TZE200_kds0pmmv)
5 participants
@matlar83 @coveralls @javicalle @dmulcahey @MattWestb