Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change first gen Hue motion replacement cluster to endpoint 2 for trigger LED #1817

Merged

Conversation

TheJulianJES
Copy link
Collaborator

First-gen Hue motion sensors have two endpoints with a Basic cluster (out) each.
For those older sensors, the LED trigger indicator attribute is on the Basic cluster on endpoint 2 (and not 1).
With these changes, it's now also tested and working on the first-gen sensors SML001 and SML002.

(Previously only working for second gen sensors: SML003 and SML004)
(The quirk for those sensors models is unaffected by this change, as it's a separate quirk in the same file.)

This should be the final PR regarding the Hue motion sensor LED trigger indicator.
(Follow-up to #1812, #1813)

First-gen Hue motion sensors have two endpoints with a Basic cluster (out) each. The LED trigger indicator attribute is on the Basic cluster on endpoint 2 and not 1
@dmulcahey dmulcahey merged commit 3f26c79 into zigpy:dev Oct 10, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3220474178

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.0%

Totals Coverage Status
Change from base Build 3212112661: 0.0%
Covered Lines: 5944
Relevant Lines: 7430

💛 - Coveralls

@TheJulianJES TheJulianJES deleted the tjj/hue_motion_fix_first_gen_sensors_led branch January 25, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants