Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python 3.10 to tox and CI #1797

Merged
merged 2 commits into from
Oct 1, 2022
Merged

Add python 3.10 to tox and CI #1797

merged 2 commits into from
Oct 1, 2022

Conversation

pdecat
Copy link
Contributor

@pdecat pdecat commented Oct 1, 2022

Hi,

I've opened this PR to reproduce some errors I am facing with python 3.10 when running tests.

All of them are like this one:

ERROR tests/test_xiaomi.py::test_xiaomi_battery[2985-118] - TypeError: Can't instantiate abstract class MockApp with abstract methods reset_network_info, send_packet

Note: python 3.10 is supported by Home Assistant since 2022/07, see https://www.home-assistant.io/blog/2022/07/06/release-20227/#improved-stability-and-performance-and-python-310

@coveralls
Copy link

coveralls commented Oct 1, 2022

Pull Request Test Coverage Report for Build 3165372359

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 71.699%

Totals Coverage Status
Change from base Build 3139653088: 0.04%
Covered Lines: 5310
Relevant Lines: 7406

💛 - Coveralls

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2022

Codecov Report

Base: 71.66% // Head: 71.69% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (d2adc08) compared to base (b8d8480).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1797      +/-   ##
==========================================
+ Coverage   71.66%   71.69%   +0.03%     
==========================================
  Files         239      239              
  Lines        7396     7406      +10     
==========================================
+ Hits         5300     5310      +10     
  Misses       2096     2096              
Impacted Files Coverage Δ
zhaquirks/tuya/__init__.py 54.05% <0.00%> (+0.16%) ⬆️
zhaquirks/tuya/mcu/__init__.py 51.66% <0.00%> (+0.27%) ⬆️
zhaquirks/xbee/__init__.py 42.85% <0.00%> (+1.39%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pdecat pdecat marked this pull request as ready for review October 1, 2022 09:29
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@dmulcahey dmulcahey closed this Oct 1, 2022
@dmulcahey dmulcahey reopened this Oct 1, 2022
@dmulcahey dmulcahey merged commit aa476ad into zigpy:dev Oct 1, 2022
@pdecat pdecat deleted the py310 branch October 1, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants