update aqara airmonitor tvoc for 0.0.0_0029 FW #1598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated my sensor to the latest firmware: Koenkk/zigbee-OTA#86 It totally changed the device signature (makes little sense): ``` { "node_descriptor": "NodeDescriptor(logical_type=<LogicalType.EndDevice: 2>, complex_descriptor_available=0, user_descriptor_available=0, reserved=0, aps_flags=0, frequency_band=<FrequencyBand.Freq2400MHz: 8>, mac_capability_flags=<MACCapabilityFlags.AllocateAddress: 128>, manufacturer_code=4447, maximum_buffer_size=127, maximum_incoming_transfer_size=100, server_mask=11264, maximum_outgoing_transfer_size=100, descriptor_capability_field=<DescriptorCapability.NONE: 0>, *allocate_address=True, *is_alternate_pan_coordinator=False, *is_coordinator=False, *is_end_device=True, *is_full_function_device=False, *is_mains_powered=False, *is_receiver_on_when_idle=False, *is_router=False, *is_security_capable=False)", "endpoints": { "1": { "profile_id": 260, "device_type": "0x0402", "in_clusters": [ "0x0000", "0x0001", "0x0003", "0x0500" ], "out_clusters": [ "0x0019" ] } }, "manufacturer": "LUMI", "model": "lumi.airmonitor.acn01", "class": "zigpy.device.Device" } ``` PR adds a new class to match the new signature - tested and wokring.
Pull Request Test Coverage Report for Build 2435869737
💛 - Coveralls |
Whoops - Big clean up from that first try.
Codecov Report
@@ Coverage Diff @@
## dev #1598 +/- ##
==========================================
- Coverage 80.25% 80.23% -0.03%
==========================================
Files 231 231
Lines 6932 6940 +8
==========================================
+ Hits 5563 5568 +5
- Misses 1369 1372 +3
Continue to review full report at Codecov.
|
dmulcahey
approved these changes
Jun 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated my sensor to the latest firmware from Koenkk/zigbee-OTA#86
It changed the device signature (which now makes little sense):
PR adds a new class to match the new signature and retains the replacement clusters - tested and working.