Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hue in Wall Switch - RDM001 #1434

Merged
merged 1 commit into from
Mar 24, 2022
Merged

Hue in Wall Switch - RDM001 #1434

merged 1 commit into from
Mar 24, 2022

Conversation

tube0013
Copy link
Contributor

Add Support for Hue In Wall Switch. has been working for me. might need some clean up of the device automations?

Add Support for Hue In Wall Switch
@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2022

Codecov Report

Attention: Patch coverage is 75.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 80.44%. Comparing base (d60fa3d) to head (9fd5902).
Report is 774 commits behind head on dev.

Files with missing lines Patch % Lines
zhaquirks/philips/rdm001.py 75.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1434      +/-   ##
==========================================
- Coverage   80.47%   80.44%   -0.04%     
==========================================
  Files         225      226       +1     
  Lines        6505     6541      +36     
==========================================
+ Hits         5235     5262      +27     
- Misses       1270     1279       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1994727016

  • 27 of 36 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 80.446%

Changes Missing Coverage Covered Lines Changed/Added Lines %
zhaquirks/philips/rdm001.py 27 36 75.0%
Totals Coverage Status
Change from base Build 1976830509: -0.03%
Covered Lines: 5262
Relevant Lines: 6541

💛 - Coveralls

@BrammyS
Copy link

BrammyS commented Mar 22, 2022

I'd love to test this as well, but can't seem to find any way how. Can you point me into the right direction? :P

@tube0013
Copy link
Contributor Author

check here:

#858 (comment)

@BrammyS
Copy link

BrammyS commented Mar 22, 2022

Everything seems to be working fine!
Added the custom quirk and an automation for it.

@dmulcahey dmulcahey merged commit df9bdca into zigpy:dev Mar 24, 2022
@apadua
Copy link

apadua commented Aug 29, 2022

Hi Everyone. Mine works but only one port (LEFT). Is there a way to configure/enable support of the 2nd toggle? I’ve tried an old one i removed from the Hue hub and a net-new one from the sealed box.

@evpaassen
Copy link

Hi Everyone. Mine works but only one port (LEFT). Is there a way to configure/enable support of the 2nd toggle? I’ve tried an old one i removed from the Hue hub and a net-new one from the sealed box.

You might find some useful information here: #858 (comment) (and reply #858 (comment)). I'm not sure the second toggle is supported in the UI already, but you should be able to get it working by adding a trigger on a custom ZHA event.

@apadua
Copy link

apadua commented Sep 8, 2022

Yes, thank you. you nailed it. I've managed to deal with it this way. There's still a lot not supported - double click events don't work, etc (note for future readers), but i got both buttons to work for the basics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants