Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove @Vector #6209

Closed
wants to merge 1 commit into from
Closed

Remove @Vector #6209

wants to merge 1 commit into from

Conversation

tadeokondrak
Copy link
Contributor

#5207
Doesn't remove it from generated names (and thus errors) because I'm not sure what to replace it with.

@tadeokondrak tadeokondrak force-pushed the remove-@Vector branch 2 times, most recently from b60aeee to aea36cf Compare August 31, 2020 02:04
@andrewrk
Copy link
Member

I think @Vector may be an exception from #5207 because it is a stand-in for the fact that we are missing vector type syntax, as evidenced by generated names and errors needing to specify the type. I am hesitant to merge this because I think we probably should have vector syntax, and that is what @Vector should become.

Also was the CI ever passing?

@andrewrk andrewrk mentioned this pull request Oct 22, 2020
Open
@andrewrk
Copy link
Member

I think we probably should have vector syntax, and that is what @Vector should become.

=> #6771

@andrewrk
Copy link
Member

Hang on to the branch and re-open pending the conclusion of #6771

@andrewrk andrewrk closed this Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tadeokondrak @andrewrk