Implement stack probes for x86 #2440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LemonBoy
force-pushed
the
stack-probe
branch
2 times, most recently
from
241a04e
to
a72015f
Compare
daurnimator
reviewed
May 8, 2019
| // __chkstk | yes | no | | ||
| // __chkstk_ms | no | no | | ||
| // ___chkstk (__alloca) | yes | yes | | ||
| // ___chkstk_ms | no | no | |
There was a problem hiding this comment.
Is this the same as __chkstk_ms then? Could you make it an alias?
Similar for ___chkstk and _chkstk
There was a problem hiding this comment.
Having them defined on their own is helpful because one more (or one less) underscore may break your stack.
Enabled on non-Windows systems only since it already requires stack probes.
|
Nice work! |
andrewrk
reviewed
May 8, 2019
| // Define this symbol here so that we can link with the zig objects during the | ||
| // compiler bootstrap phase | ||
| extern "C" { | ||
| void __zig_probe_stack(void) { } |
There was a problem hiding this comment.
@LemonBoy why was this needed? I tried removing this and it seems to work fine
There was a problem hiding this comment.
I needed that in order not to do a fresh rebuild when I first added the stack probe annotation, you can safely remove it now.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #530