fix color preference parsing from env #22497
Open
+20
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifies the preference parsing code to correctly assert the NO_COLOR environment variable's value is not an empty string. Closes ziglang#22380.
linusg
reviewed
Jan 16, 2025
| @@ -45,6 +48,20 @@ pub const Color = enum { | |||
| /// Assume stderr is a terminal. | |||
| on, | |||
|
|
|||
| pub fn getEnv(arena: std.mem.Allocator) !Color { | |||
There was a problem hiding this comment.
I feel like something like getFromEnv would be more appropriate naming-wise
ifreund
requested changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies the preference parsing code to correctly
assert the NO_COLOR environment variable's value
is not an empty string.
Closes #22380.