Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main: Don't pass --seed for zig run. #20796

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Conversation

alexrp
Copy link
Member

@alexrp alexrp commented Jul 26, 2024

Looks like an accidental effect introduced in #20750.

Had me questioning reality for a bit before I realized what was going on:

❯ zig run generate_linux_syscalls.zig -- $(which zig) /home/alexrp/Source/linux
error: NotDir
/home/alexrp/Source/zig/lib/std/posix.zig:1783:24: 0x108024f in openatZ (generate_linux_syscalls)
            .NOTDIR => return error.NotDir,
                       ^
/home/alexrp/Source/zig/lib/std/fs/Dir.zig:1565:21: 0x1090736 in openDirFlagsZ (generate_linux_syscalls)
        else => |e| return e,
                    ^
/home/alexrp/Source/zig/lib/std/fs/Dir.zig:1529:5: 0x107fef2 in openDirZ (generate_linux_syscalls)
    return self.openDirFlagsZ(sub_path_c, symlink_flags);
    ^
/home/alexrp/Source/zig/lib/std/fs/Dir.zig:1473:5: 0x104cace in openDir (generate_linux_syscalls)
    return self.openDirZ(&sub_path_c, args);
    ^
/home/alexrp/Source/zig/lib/std/fs.zig:283:5: 0x10460bb in openDirAbsolute (generate_linux_syscalls)
    return cwd().openDir(absolute_path, flags);
    ^
/home/alexrp/Source/zig/tools/generate_linux_syscalls.zig:66:23: 0x103d9f3 in main (generate_linux_syscalls)
    const linux_dir = try std.fs.openDirAbsolute(linux_path, .{});

@andrewrk
Copy link
Member

Oops, thank you!

@andrewrk andrewrk merged commit 9536d65 into ziglang:master Jul 26, 2024
4 of 10 checks passed
@alexrp alexrp deleted the patch-1 branch July 26, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants