Step.WriteFile: Iterate directories when adding data to cache hash #20573
Conversation
| for (dir.options.exclude_extensions) |ext| { | ||
| if (std.mem.endsWith(u8, entry.path, ext)) continue :next_entry; | ||
| } | ||
| if (dir.options.include_extensions) |incs| { | ||
| for (incs) |inc| { | ||
| if (std.mem.endsWith(u8, entry.path, inc)) break; | ||
| } else { | ||
| continue :next_entry; | ||
| } | ||
| } |
There was a problem hiding this comment.
This logic seems duplicated in fn make.
We could have a shared function Directory.Options.isFilePathExcluded(options: Directory.Options, file_path: []const u8) bool -> if(dir.options.isFilePathExcluded(entry)) continue; to make sure they stay in-sync.
|
Not directly related to this change, but I was surprised that we simply use |
|
@rohlem I agree that you have identified a better name, but I also think that the endsWith behavior is a more useful abstraction, so I think your proposed rename is the best solution. edit: changed my mind. I think the word "extension" is perfectly adequate. |
|
Thank you, it was a good effort but ultimately an incorrect implementation, and I solved it myself in fb3a441 in the "watch" branch, while adding file system watching integration at the same time. |
Fixes #20571