-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
std.Build.findProgram(): Try with and without the executable extension. #20337
Conversation
I'm a bit surprised by the order being to first append ".exe" before trying the name verbatim. I realize this would technically be a breaking change to edge cases otherwise, |
That strikes me as enough of an edge case that I really have no strong feelings on it. I'm fine with either order. |
a744b1e
to
551e485
Compare
@rohlem @squeek502 I think this should cover what we discussed in #20314. |
551e485
to
c2e92de
Compare
c2e92de
to
ae08da9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I think this is good enough to merge, however, I have a request that will eliminate the need for those "keep in sync" comments.
ae08da9
to
071c2e4
Compare
…extensions. I renamed std.process.Child.CreateProcessSupportedExtension to WindowsExtension and made it public to avoid duplicating the list of extensions. While here, I also improved it to not misreport OOM from std.fs.realpathAlloc() as a generic failure to find the program, but instead panic like the rest of the build system does for OOM. Closes ziglang#20314.
071c2e4
to
b83bf58
Compare
Ok, I think this should be good to go. |
Thanks! |
While here, I also improved it to not misreport OOM from std.fs.realpathAlloc() as a generic failure to find the program, but instead panic like the rest of the build system does for OOM.
This is the fix I proposed in #20314.