Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch: Keep .lazy = true #19816

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

der-teufel-programming
Copy link
Contributor

Solves #19725

@rupakhetibinit
Copy link

This seems like a wrong way to do it. If we currently have guarantees that zig fetch --save <url> only needs to change the url and the hash, I think a better implementation is to change the url and the hash and to not touch any other fields.

The way this PR is done, it only works in current context, what if in the future another field is introduced for another use-case. It just doesn't seem practical to keep changing it on every new field that is added increasing maintenance burden.

But that's just my 2 cents. Maybe some core team member can chime in and give feedback.

Copy link
Member

@andrewrk andrewrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @rupakhetibinit

@der-teufel-programming
Copy link
Contributor Author

I've changed the implementation to now only touch the hash and location fields when updating dependencies

@andrewrk andrewrk merged commit 4d09fb4 into ziglang:master Sep 24, 2024
10 checks passed
@andrewrk
Copy link
Member

Thanks!

DivergentClouds pushed a commit to DivergentClouds/zig that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants