spirv: remove cache #19562
Merged
spirv: remove cache #19562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snektron
force-pushed
the
spirv-remove-cache
branch
4 times, most recently
from
e4236bd
to
8c07855
Compare
Snektron
force-pushed
the
spirv-remove-cache
branch
2 times, most recently
from
2f6d954
to
2d778cc
Compare
This allows us to more sanely allocate a continuous range of result-ids, and avoids a bunch of nasty casting code in a few places. Its currently not used very often, but will be useful in the future.
Snektron
force-pushed
the
spirv-remove-cache
branch
from
2d778cc
to
cbf2ee7
Compare
|
Nice. I think it's a good decision. |
andrewrk
approved these changes
Apr 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have the intern pool in Zig for cheap hashing/equality of types and values, and the deduplication pass (see #19490), we can get rid of SPIR-V's type/constant cache. There are still some cases where it is required, and for those situations we keep an ad-hoc cache of only those types (see
cacheinsrc/codegen/spirv/Module.zig).This PR is based on #18984, so that should be merged first