fix broken and confusing artifact installation logic #15245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewrk
added
breaking
andrewrk
force-pushed
the
zig-build-install-artifact
branch
from
4849ee3 to
677e1c9
Compare
The destination *Build object is already known to be step.owner, while the source object is artifact.step.owner.
This was used to ensure that an artifact would only be installed once, but this is not only unnecessary, but actively harmful, in the face of dependencies. see #15079
These functions are problematic in light of dependencies because they run and install, respectively, for the *owner* package rather than for the *user* package. By removing these functions, the build script is forced to provide the *Build object to associate the new step with, making everything less surprising. Unfortunately, this is a widely breaking change. see #15079
Instead, ignore stdin. Otherwise this interfers with a sub-process which expects to have a stdin file descriptor open.
And while we're at it, make the unit tests be actually executed.
andrewrk
force-pushed
the
zig-build-install-artifact
branch
from
677e1c9 to
406706f
Compare
This was referenced Apr 11, 2023
Closed
zshipko
pushed a commit
to extism/extism
that referenced
this pull request
Apr 14, 2023
Fixes breaking build system changes introduced in ziglang/zig#15245
This was referenced Apr 17, 2023
bhelx
pushed a commit
to extism/zig-sdk
that referenced
this pull request
Sep 13, 2023
Fixes breaking build system changes introduced in ziglang/zig#15245
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commit messages for more information.
closes #15079