remove --enable-cache option; std.Build.CompileStep: remove output_dir #15234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewrk
added
breaking
andrewrk
force-pushed
the
remove-legacy-build-api
branch
from
a8a63f8 to
31b24a5
Compare
Build scripts must instead use the FileSource abstraction rather than telling the compiler directly where to output files. closes #14951
* remove setName, setFilter, and setTestRunner. Please set these options directly when creating the CompileStep. * removed unused field * remove computeOutFileNames and inline the logic, making clear the goal of avoiding state mutations after the build step is created.
andrewrk
force-pushed
the
remove-legacy-build-api
branch
from
31b24a5 to
3c3cee2
Compare
Where is the
Or otherwise, any pointers to where to look to cover the usecase of "I have a build step and I want to ensure that the output directory is this specific directory"? Note that thread 22906074 panic: Cannot install a .obj build artifact.
/Users/jarred/zig/0.11.0-dev.2571+31738de28/files/lib/std/Build/InstallArtifactStep.zig:30:21: 0x102e6a80b in create (build)
.obj => @panic("Cannot install a .obj build artifact."),
^
/Users/jarred/zig/0.11.0-dev.2571+31738de28/files/lib/std/Build.zig:1177:38: 0x102e177a7 in addInstallArtifact (build)
return InstallArtifactStep.create(self, artifact);
^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std.Build.CompileStep: remove output_dir
Build scripts must instead use the FileSource abstraction rather than
telling the compiler directly where to output files.
CLI: remove --enable-cache option
This use case is now handled instead by the --listen option.
closes #14951
closes #15025
closes #15072