Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linker flag --enable-auto-image-base is not recognized #19613

Open
alexrp opened this issue Apr 11, 2024 · 3 comments · May be fixed by #21603
Open

Linker flag --enable-auto-image-base is not recognized #19613

alexrp opened this issue Apr 11, 2024 · 3 comments · May be fixed by #21603
Assignees
@alexrp
Labels
bug Observed behavior contradicts documented or intended behavior linking zig cc Zig as a drop-in C compiler feature
Milestone
0.16.0

Comments

@alexrp
Copy link
Member

alexrp commented Apr 11, 2024 •
edited
Loading

Zig Version

0.11.0

Steps to Reproduce and Observed Behavior

Build an Autotools project with zig cc targeting any Windows/MinGW-w64 triple.

For example, cross-compiling libopus 1.5.1 from Linux to Windows:

$ mkdir build
$ cd build
$ ../configure --prefix=$PWD CC="zig cc -target x86-windows-gnu" --host=i686-w64-mingw32
$ make
... snip ...
  CCLD     libopus.la
error: unsupported linker arg: --enable-auto-image-base

Expected Behavior

No linker error.
@alexrp alexrp added the bug Observed behavior contradicts documented or intended behavior label Apr 11, 2024
@alexrp
Copy link
Member Author

alexrp commented Apr 11, 2024

For reference, this flag is used in Libtool:

@tannal
Copy link

tannal commented May 11, 2024

Box64 also need this.
https://github.com/ptitSeb/box64/blob/46dfaab639b7d2a5af79c288160bfe92b1fd6961/CMakeLists.txt#L937-L939

@alexrp
Copy link
Member Author

alexrp commented Jun 22, 2024

Box64 also need this. https://github.com/ptitSeb/box64/blob/46dfaab639b7d2a5af79c288160bfe92b1fd6961/CMakeLists.txt#L937-L939

This seems to be --image-base? That should already be supported.

alexrp added a commit to alexrp/zig that referenced this issue Jun 22, 2024
@alexrp
Accept and ignore -(-)(enable,disable)-auto-image-base linker options.
efab16c 
These options are used by Libtool when targeting MinGW triples. They are ignored
by LLD; probably safe for us to do the same.

Closes ziglang#19613.
@alexrp alexrp mentioned this issue Jun 22, 2024
Closed
alexrp added a commit to alexrp/zig that referenced this issue Jun 22, 2024
@alexrp
Accept and ignore -(-)(enable,disable)-auto-image-base linker options.
7c9c194 
These options are used by Libtool when targeting MinGW triples. They are ignored
by LLD; probably safe for us to do the same.

Closes ziglang#19613.
@andrewrk andrewrk added the zig cc Zig as a drop-in C compiler feature label Jun 22, 2024
@andrewrk andrewrk added this to the 0.14.0 milestone Jun 22, 2024
alexrp added a commit to alexrp/zig that referenced this issue Jun 22, 2024
@alexrp
Accept and ignore -(-)(enable,disable)-auto-image-base linker options.
f59e911 
These options are used by Libtool when targeting MinGW triples. They are ignored
by LLD; probably safe for us to do the same.

Closes ziglang#19613.
alexrp added a commit to alexrp/zig that referenced this issue Jul 3, 2024
@alexrp
Accept and ignore -(-)(enable,disable)-auto-image-base linker options.
134955d 
These options are used by Libtool when targeting MinGW triples. They are ignored
by LLD; probably safe for us to do the same.

Closes ziglang#19613.
alexrp added a commit to alexrp/zig that referenced this issue Jul 7, 2024
@alexrp
Accept and ignore -(-)(enable,disable)-auto-image-base linker options.
4853fba 
These options are used by Libtool when targeting MinGW triples. They are ignored
by LLD; probably safe for us to do the same.

Closes ziglang#19613.
alexrp added a commit to alexrp/zig that referenced this issue Jul 9, 2024
@alexrp
Accept and ignore -(-)(enable,disable)-auto-image-base linker options.
40cf5fd 
These options are used by Libtool when targeting MinGW triples. They are ignored
by LLD; probably safe for us to do the same.

Closes ziglang#19613.
alexrp added a commit to alexrp/zig that referenced this issue Jul 20, 2024
@alexrp
Accept and ignore -(-)(enable,disable)-auto-image-base linker options.
1ec5729 
These options are used by Libtool when targeting MinGW triples. They are ignored
by LLD; probably safe for us to do the same.

Closes ziglang#19613.
alexrp added a commit to alexrp/zig that referenced this issue Aug 1, 2024
@alexrp
Accept and ignore -(-)(enable,disable)-auto-image-base linker options.
4323dbe 
These options are used by Libtool when targeting MinGW triples. They are ignored
by LLD; probably safe for us to do the same.

Closes ziglang#19613.
alexrp added a commit to alexrp/zig that referenced this issue Aug 1, 2024
@alexrp
Accept and ignore -(-)(enable,disable)-auto-image-base linker options.
003c5c4 
These options are used by Libtool when targeting MinGW triples. They are ignored
by LLD; probably safe for us to do the same.

Closes ziglang#19613.
@andrewrk andrewrk modified the milestones: 0.14.0, 0.16.0 Aug 8, 2024
alexrp added a commit to alexrp/zig that referenced this issue Aug 28, 2024
@alexrp
Accept and ignore -(-)(enable,disable)-auto-image-base linker options.
2b9b710 
These options are used by Libtool when targeting MinGW triples. They are ignored
by LLD; probably safe for us to do the same.

Closes ziglang#19613.
@alexrp alexrp added the linking label Oct 3, 2024
alexrp added a commit to alexrp/zig that referenced this issue Oct 5, 2024
@alexrp
compiler: Accept and ignore --(enable,disable)-auto-image-base link…
f82d55c 
…er options.

Closes ziglang#19613.
@alexrp alexrp linked a pull request Oct 5, 2024 that will close this issue
Open
@alexrp alexrp changed the title Linker flag --enable-auto-image-base is not supported Linker flag --enable-auto-image-base is not recognized Oct 6, 2024
alexrp added a commit to alexrp/zig that referenced this issue Oct 15, 2024
@alexrp
compiler: Accept and ignore --(enable,disable)-auto-image-base link…
71db948 
…er options.

Closes ziglang#19613.
alexrp added a commit to alexrp/zig that referenced this issue Oct 26, 2024
@alexrp
compiler: Accept and ignore --(enable,disable)-auto-image-base link…
7eec7ba 
…er options.

Closes ziglang#19613.
@alexrp alexrp self-assigned this Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexrp alexrp

Labels
bug Observed behavior contradicts documented or intended behavior linking zig cc Zig as a drop-in C compiler feature
Projects
None yet
Milestone
0.16.0
3 participants
@alexrp @andrewrk @tannal