Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

posix_spawnattr_destroy incorrect return type #12964

Closed
Jarred-Sumner opened this issue Sep 25, 2022 · 1 comment · Fixed by #12999
Closed

posix_spawnattr_destroy incorrect return type #12964

Jarred-Sumner opened this issue Sep 25, 2022 · 1 comment · Fixed by #12999
Labels
bug Observed behavior contradicts documented or intended behavior contributor friendly This issue is limited in scope and/or knowledge of Zig internals. standard library This issue involves writing Zig code for the standard library.
Milestone
0.10.0

Comments

@Jarred-Sumner
Copy link
Contributor

From spawn.h on macOS:

int     posix_spawnattr_destroy(posix_spawnattr_t *) __API_AVAILABLE(macos(10.5), ios(2.0)) __API_UNAVAILABLE(watchos, tvos);

It should be c_int

zig/lib/std/c/darwin.zig

Line 83 in 6d7b069

pub extern "c" fn posix_spawnattr_destroy(attr: *posix_spawnattr_t) void;

@Jarred-Sumner
Copy link
Contributor Author

Same for posix_spawn_file_actions_destroy

@Vexu Vexu added bug Observed behavior contradicts documented or intended behavior contributor friendly This issue is limited in scope and/or knowledge of Zig internals. standard library This issue involves writing Zig code for the standard library. labels Sep 26, 2022
@Vexu Vexu added this to the 0.11.0 milestone Sep 26, 2022
alichraghi added a commit to alichraghi/zig that referenced this issue Sep 28, 2022
@alichraghi
std.c: fix incorrect return types
194cbd6 
Closes ziglang#12964
@alichraghi alichraghi mentioned this issue Sep 28, 2022
Merged
alichraghi added a commit to alichraghi/zig that referenced this issue Sep 30, 2022
@alichraghi
std.c: fix incorrect return types
c20ab7f 
Closes ziglang#12964
alichraghi added a commit to alichraghi/zig that referenced this issue Sep 30, 2022
@alichraghi
std.c: fix incorrect return types
8c3be83 
Closes ziglang#12964
alichraghi added a commit to alichraghi/zig that referenced this issue Sep 30, 2022
@alichraghi
std.c: fix incorrect return types
ca11382 
Closes ziglang#12964
alichraghi added a commit to alichraghi/zig that referenced this issue Oct 3, 2022
@alichraghi
std.c: fix incorrect return types
f35e78e 
Closes ziglang#12964
alichraghi added a commit to alichraghi/zig that referenced this issue Oct 3, 2022
@alichraghi
std.c: fix incorrect return types
e2fd44c 
Closes ziglang#12964
Vexu pushed a commit that referenced this issue Oct 13, 2022
@alichraghi @Vexu
std.c: fix incorrect return types
fb366f3 
Closes #12964
@Vexu Vexu modified the milestones: 0.11.0, 0.10.0 Oct 13, 2022
@vjpr vjpr mentioned this issue Nov 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Observed behavior contradicts documented or intended behavior contributor friendly This issue is limited in scope and/or knowledge of Zig internals. standard library This issue involves writing Zig code for the standard library.
Projects
None yet
Milestone
0.10.0
Development

Successfully merging a pull request may close this issue.

std.c: fix incorrect return types alichraghi/zig
2 participants
@Jarred-Sumner @Vexu