Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add secure option to context #23

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Add secure option to context #23

merged 2 commits into from
Apr 12, 2024

Conversation

dimoschi
Copy link
Contributor

Required if you need to connect to a managed Clickhouse, e.g. aiven

@dimoschi dimoschi requested a review from zifter as a code owner March 20, 2024 12:23
@dimoschi
Copy link
Contributor Author

@zifter any chance this PR to be reviewed?

@zifter
Copy link
Owner

zifter commented Apr 10, 2024

@dimoschi sorry, missed the notification
when tests passed, I will merge and prepare release

@dimoschi
Copy link
Contributor Author

@dimoschi sorry, missed the notification

when tests passed, I will merge and prepare release

Thanks, I wasn't sure about the tests, I was expecting them to pass. Can take a look if you want.

@zifter
Copy link
Owner

zifter commented Apr 11, 2024

@dimoschi sorry, missed the notification
when tests passed, I will merge and prepare release

Thanks, I wasn't sure about the tests, I was expecting them to pass. Can take a look if you want.

just have a look my comment, I suppose it will fix tests
#23 (comment)

@dimoschi
Copy link
Contributor Author

@dimoschi sorry, missed the notification
when tests passed, I will merge and prepare release

Thanks, I wasn't sure about the tests, I was expecting them to pass. Can take a look if you want.

just have a look my comment, I suppose it will fix tests #23 (comment)

I changed the default to zero. I saw your comments from the phone app and totally missed the #23 (comment)

@zifter zifter merged commit fa9e178 into zifter:main Apr 12, 2024
5 checks passed
@zifter
Copy link
Owner

zifter commented Apr 12, 2024

@dimoschi thank you for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants