Skip to content

Commit

Permalink
fixup
Browse files Browse the repository at this point in the history
  • Loading branch information
zhztheplayer committed Aug 19, 2024
1 parent 1c04efd commit 05e1e2b
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
5 changes: 5 additions & 0 deletions velox/common/memory/MemoryPool.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,11 @@

#include <re2/re2.h>

DEFINE_bool(
memory_pool_capacity_transfer_across_tasks,
false,
"Whether allow to memory capacity transfer between memory pools from different tasks, which might happen in use case like Spark-Gluten");

DECLARE_bool(velox_suppress_memory_capacity_exceeding_error_message);

using facebook::velox::common::testutil::TestValue;
Expand Down
5 changes: 0 additions & 5 deletions velox/exec/MemoryReclaimer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,6 @@
#include "velox/exec/Driver.h"
#include "velox/exec/Task.h"

DEFINE_bool(
transferred_arbitration_allowed,
false,
"Whether to allow entering memory arbitration on memory pool that is from another task");

namespace facebook::velox::exec {
std::unique_ptr<memory::MemoryReclaimer> MemoryReclaimer::create() {
return std::unique_ptr<memory::MemoryReclaimer>(new MemoryReclaimer());
Expand Down
2 changes: 1 addition & 1 deletion velox/exec/MemoryReclaimer.h
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

#include "velox/common/memory/MemoryArbitrator.h"

DECLARE_bool(transferred_arbitration_allowed);
DECLARE_bool(memory_pool_capacity_transfer_across_tasks);

namespace facebook::velox::exec {
/// Provides the default leaf memory reclaimer implementation for velox task
Expand Down

0 comments on commit 05e1e2b

Please sign in to comment.