feat: ✨ add new attributes to user

libs/users/application/src/lib/use-cases/get-user.use-case.spec.ts

@@ -14,7 +14,12 @@ describe('GetUserUseCase', () => {
 
   describe('execute', () => {
     it('should return user when found', async () => {
-      const mockUser = { id: '1', name: 'John Doe' };
+      const mockUser = {
+        id: '1',
+        email: '[email protected]',
+        firstName: 'John',
+        lastName: 'Doe',
+      };
       (usersRepository.findById as jest.Mock).mockResolvedValue(mockUser);
 
       const result = await getUserUseCase.execute('1');
@@ -32,4 +37,4 @@ describe('GetUserUseCase', () => {
       expect(usersRepository.findById).toHaveBeenCalledWith('1');
     });
   });
-});
+});

libs/users/application/src/lib/users.service.spec.ts

@@ -30,7 +30,12 @@ describe('UsersService', () => {
 
   describe('findById', () => {
     it('should return a user if found', async () => {
-      const user: User = { id: '1', name: 'John Doe' };
+      const user: User = {
+        id: '1',
+        email: '[email protected]',
+        firstName: 'John',
+        lastName: 'Doe',
+      };
       jest.spyOn(getUserUseCase, 'execute').mockResolvedValue(user);
 
       const result = await service.findById('1');

libs/users/domain/src/lib/user.entity.spec.ts

@@ -1,15 +1,46 @@
 import { User } from './user.entity';
 
 describe('User Entity', () => {
-  it('should create a user with id and name', () => {
-    const user = new User('1', 'John Doe');
-    expect(user.id).toBe('1');
-    expect(user.name).toBe('John Doe');
+  it('should create a user with all required fields', () => {
+    const user = new User('123', '[email protected]', 'John', 'Doe');
+
+    expect(user.id).toBe('123');
+    expect(user.email).toBe('[email protected]'); 
+    expect(user.firstName).toBe('John');
+    expect(user.lastName).toBe('Doe');
+  });
+
+  it('should allow updating first name', () => {
+    const user = new User('123', '[email protected]', 'John', 'Doe');
+    user.firstName = 'Jane';
+    expect(user.firstName).toBe('Jane');
+  });
+
+  it('should allow updating last name', () => {
+    const user = new User('123', '[email protected]', 'John', 'Doe');
+    user.lastName = 'Smith';
+    expect(user.lastName).toBe('Smith');
+  });
+
+  it('should allow updating first name and last name', () => {
+    const user = new User('123', '[email protected]', 'John', 'Doe');
+    user.firstName = 'Jane';
+    user.lastName = 'Smith';
+    expect(user.firstName).toBe('Jane');
+    expect(user.lastName).toBe('Smith');
+  });
+
+  it('should allow null values for first name and last name', () => {
+    const user = new User('123', '[email protected]', null, null);
+    expect(user.firstName).toBeNull();
+    expect(user.lastName).toBeNull();
   });
 
-  it('should allow updating the name', () => {
-    const user = new User('1', 'John Doe');
-    user.name = 'Jane Doe';
-    expect(user.name).toBe('Jane Doe');
+  it('should allow setting first name and last name to null', () => {
+    const user = new User('123', '[email protected]', 'John', 'Doe');
+    user.firstName = null;
+    user.lastName = null;
+    expect(user.firstName).toBeNull(); 
+    expect(user.lastName).toBeNull();
   });
 });

libs/users/domain/src/lib/user.entity.ts

@@ -1,6 +1,8 @@
 export class User {
   constructor(
     public readonly id: string,
-    public name: string,
+    public readonly email: string,
+    public firstName: string | null,
+    public lastName: string | null,
   ) {}
 }

libs/users/domain/src/lib/users.repository.spec.ts

@@ -3,8 +3,13 @@ import { User } from './user.entity';
 
 class MockUsersRepository implements UsersRepository {
   private users: User[] = [
-    { id: '1', name: 'John Doe' },
-    { id: '2', name: 'Jane Doe' },
+    { id: '1', email: '[email protected]', firstName: 'John', lastName: 'Doe' },
+    {
+      id: '2',
+      email: '[email protected]',
+      firstName: 'Jane',
+      lastName: 'Smith',
+    },
   ];
 
   async findById(id: string): Promise<User | null> {
@@ -21,7 +26,12 @@ describe('UsersRepository', () => {
 
   test('findById should return a user by id', async () => {
     const user = await usersRepository.findById('1');
-    expect(user).toEqual({ id: '1', name: 'John Doe' });
+    expect(user).toEqual({
+      id: '1',
+      email: '[email protected]',
+      firstName: 'John',
+      lastName: 'Doe'
+    });
   });
 
   test('findById should return null if user not found', async () => {

libs/users/infrastructure/mongoose/src/lib/mongoose-users.repository.spec.ts

@@ -23,13 +23,17 @@ describe('MongooseUsersRepository', () => {
     }).compile();
 
     repository = module.get<MongooseUsersRepository>(MongooseUsersRepository);
-    userModel = module.get<Model<UserDocument>>(getModelToken(UserDocument.name));
+    userModel = module.get<Model<UserDocument>>(
+      getModelToken(UserDocument.name),
+    );
   });
 
   it('should return a user when found', async () => {
     const mockUser = {
       id: '507f1f77bcf86cd799439011',
-      name: 'Test User',
+      email: '[email protected]',
+      firstName: 'John',
+      lastName: 'Doe',
     };
 
     jest.spyOn(userModel, 'findById').mockReturnValue({
@@ -39,7 +43,9 @@ describe('MongooseUsersRepository', () => {
     const user = await repository.findById(mockUser.id);
     expect(user).toBeInstanceOf(User);
     expect(user?.id).toBe(mockUser.id);
-    expect(user?.name).toBe(mockUser.name);
+    expect(user?.email).toBe(mockUser.email);
+    expect(user?.firstName).toBe(mockUser.firstName);
+    expect(user?.lastName).toBe(mockUser.lastName);
   });
 
   it('should return null when user is not found', async () => {
@@ -50,4 +56,4 @@ describe('MongooseUsersRepository', () => {
     const user = await repository.findById('507f1f77bcf86cd799439011');
     expect(user).toBeNull();
   });
-});
+});

libs/users/infrastructure/mongoose/src/lib/mongoose-users.repository.ts

@@ -12,13 +12,17 @@ export class MongooseUsersRepository implements UsersRepository {
   ) {}
 
   async findById(id: string): Promise<User | null> {
-
     const _id = new Types.ObjectId(id);
     const userDocument = await this.userModel.findById(_id).exec();
 
     if (!userDocument) {
       return null;
     }
-    return new User(userDocument.id, userDocument.name);
+    return new User(
+      userDocument.id,
+      userDocument.email,
+      userDocument.firstName,
+      userDocument.lastName,
+    );
   }
 }

libs/users/infrastructure/mongoose/src/lib/user.schema.ts

@@ -4,7 +4,13 @@ import { Document } from 'mongoose';
 @Schema()
 export class UserDocument extends Document {
   @Prop({ required: true })
-  name!: string;
+  email!: string;
+
+  @Prop({ required: true, nullable: true })
+  firstName!: string;
+
+  @Prop({ required: true, nullable: true })
+  lastName!: string;
 }
 
-export const UserSchema = SchemaFactory.createForClass(UserDocument);
+export const UserSchema = SchemaFactory.createForClass(UserDocument);

libs/users/interface-adapters/src/lib/dto/user.dto.spec.ts

@@ -3,11 +3,11 @@ import { UserDto } from './user.dto';
 describe('UserDto', () => {
   it('should create a new UserDto instance', () => {
     const id = '123';
-    const name = 'Test User';
-    const userDto = new UserDto(id, name);
+    const email = '[email protected]';
+    const firstName = 'John';
+    const lastName = 'Doe';
+    const userDto = new UserDto(id, email, firstName, lastName);
 
     expect(userDto).toBeDefined();
-    expect(userDto.id).toBe(id);
-    expect(userDto.name).toBe(name);
   });
 });

libs/users/interface-adapters/src/lib/dto/user.dto.ts

@@ -6,10 +6,23 @@ export class UserDto {
   id: string;
 
   @Field()
-  name: string;
+  email: string;
 
-  constructor(id: string, name: string) {
+  @Field()
+  firstName: string | null;
+
+  @Field()
+  lastName: string | null;
+
+  constructor(
+    id: string,
+    email: string,
+    firstName: string | null,
+    lastName: string | null,
+  ) {
     this.id = id;
-    this.name = name;
+    this.email = email;
+    this.firstName = firstName;
+    this.lastName = lastName;
   }
 }

libs/users/interface-adapters/src/lib/resolver/users.resolver.spec.ts

@@ -1,6 +1,5 @@
 import { Test, TestingModule } from '@nestjs/testing';
 import { UsersService } from '@users/application';
-import { User } from '@users/domain';
 
 import { UsersResolver } from './users.resolver';
 

libs/users/interface-adapters/src/lib/resolver/users.resolver.ts

@@ -1,5 +1,6 @@
 import { Args, ID, Query, Resolver } from '@nestjs/graphql';
 import { UsersService } from '@users/application';
+import { User } from '@users/domain';
 
 import { UserDto } from '../dto/user.dto';
 
@@ -9,12 +10,12 @@ export class UsersResolver {
 
   @Query(() => UserDto, { nullable: true })
   async getUser(@Args({ name: 'id', type: () => ID }) id: string): Promise<UserDto | null> {
-    const user = await this.usersService.findById(id);
+    const user: User| null = await this.usersService.findById(id);
 
     if (!user) {
       return null;
     }
 
-    return new UserDto(user.id, user.name);
+    return new UserDto(user.id, user.email, user.firstName, user.lastName);
   }
 }