Make the output sameplerate match the input #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 3 arguments that are passed into the
Mp3Encoder
(channels,samplerate and kbps).
The input samplerate is generally dependant on
AudioContext.sampleRate
andthis varies from machine-to-machine.
I was having resampling issues until I make the output samplerate match the
input samplerate. Now everything is OK and I get what I am expecting from my
encoded audio.
A note to others who may read this, ensure that you use the sample rate
provided from
AudioContext
if you're encoding audio from the users mic inorder to avoid strange resampling issues (different pitch, playback rate etc)