[iOS] Fabric: make built-in components recycle optional

zhongwuzw · Feb 1, 2024 · 843b93e · 843b93e
1 parent ebc2831
commit 843b93e
Show file tree

Hide file tree

Showing 20 changed files with 56 additions and 0 deletions.
diff --git a/...Fabric/Mounting/ComponentViews/ActivityIndicator/RCTActivityIndicatorViewComponentView.mm b/...Fabric/Mounting/ComponentViews/ActivityIndicator/RCTActivityIndicatorViewComponentView.mm
@@ -91,6 +91,8 @@ - (void)updateProps:(const Props::Shared &)props oldProps:(const Props::Shared &
   [super updateProps:props oldProps:oldProps];
 }
 
+RCTComponentViewShouldBeRecycled(true);
+
 @end
 
 Class<RCTComponentViewProtocol> RCTActivityIndicatorViewCls(void)

diff --git a/...React/Fabric/Mounting/ComponentViews/DebuggingOverlay/RCTDebuggingOverlayComponentView.mm b/...React/Fabric/Mounting/ComponentViews/DebuggingOverlay/RCTDebuggingOverlayComponentView.mm
@@ -43,6 +43,8 @@ + (ComponentDescriptorProvider)componentDescriptorProvider
   return concreteComponentDescriptorProvider<DebuggingOverlayComponentDescriptor>();
 }
 
+RCTComponentViewShouldBeRecycled(true);
+
 #pragma mark - Native commands
 
 - (void)handleCommand:(const NSString *)commandName args:(const NSArray *)args

diff --git a/packages/react-native/React/Fabric/Mounting/ComponentViews/Image/RCTImageComponentView.mm b/packages/react-native/React/Fabric/Mounting/ComponentViews/Image/RCTImageComponentView.mm
@@ -125,6 +125,8 @@ - (void)prepareForRecycle
   _imageView.image = nil;
 }
 
+RCTComponentViewShouldBeRecycled(true);
+
 #pragma mark - RCTImageResponseDelegate
 
 - (void)didReceiveImage:(UIImage *)image metadata:(id)metadata fromObserver:(const void *)observer

diff --git a/...ive/React/Fabric/Mounting/ComponentViews/InputAccessory/RCTInputAccessoryComponentView.mm b/...ive/React/Fabric/Mounting/ComponentViews/InputAccessory/RCTInputAccessoryComponentView.mm
@@ -145,6 +145,8 @@ - (void)prepareForRecycle
   _textInput = nil;
 }
 
+RCTComponentViewShouldBeRecycled(true);
+
 @end
 
 Class<RCTComponentViewProtocol> RCTInputAccessoryCls(void)

diff --git a/...nting/ComponentViews/LegacyViewManagerInterop/RCTLegacyViewManagerInteropComponentView.mm b/...nting/ComponentViews/LegacyViewManagerInterop/RCTLegacyViewManagerInteropComponentView.mm
@@ -266,6 +266,8 @@ - (void)finalizeUpdates:(RNComponentViewUpdateMask)updateMask
   updatePropsIfNeeded(updateMask);
 }
 
+RCTComponentViewShouldBeRecycled(true);
+
 - (void)_setPropsWithUpdateMask:(RNComponentViewUpdateMask)updateMask
 {
   if (updateMask & RNComponentViewUpdateMaskProps) {

diff --git a/.../react-native/React/Fabric/Mounting/ComponentViews/Modal/RCTModalHostViewComponentView.mm b/.../react-native/React/Fabric/Mounting/ComponentViews/Modal/RCTModalHostViewComponentView.mm
@@ -281,6 +281,8 @@ - (void)unmountChildComponentView:(UIView<RCTComponentViewProtocol> *)childCompo
   [childComponentView removeFromSuperview];
 }
 
+RCTComponentViewShouldBeRecycled(true);
+
 @end
 
 #ifdef __cplusplus

diff --git a/packages/react-native/React/Fabric/Mounting/ComponentViews/Root/RCTRootComponentView.mm b/packages/react-native/React/Fabric/Mounting/ComponentViews/Root/RCTRootComponentView.mm
@@ -31,4 +31,6 @@ + (ComponentDescriptorProvider)componentDescriptorProvider
   return concreteComponentDescriptorProvider<RootComponentDescriptor>();
 }
 
+RCTComponentViewShouldBeRecycled(true);
+
 @end
diff --git a/...-native/React/Fabric/Mounting/ComponentViews/SafeAreaView/RCTSafeAreaViewComponentView.mm b/...-native/React/Fabric/Mounting/ComponentViews/SafeAreaView/RCTSafeAreaViewComponentView.mm
@@ -92,6 +92,8 @@ - (void)prepareForRecycle
   _state.reset();
 }
 
+RCTComponentViewShouldBeRecycled(true);
+
 @end
 
 Class<RCTComponentViewProtocol> RCTSafeAreaViewCls(void)

diff --git a/...tive/React/Fabric/Mounting/ComponentViews/ScrollView/RCTPullToRefreshViewComponentView.mm b/...tive/React/Fabric/Mounting/ComponentViews/ScrollView/RCTPullToRefreshViewComponentView.mm
@@ -84,6 +84,8 @@ - (void)updateProps:(const Props::Shared &)props oldProps:(const Props::Shared &
   [super updateProps:props oldProps:oldProps];
 }
 
+RCTComponentViewShouldBeRecycled(true);
+
 #pragma mark -
 
 - (void)handleUIControlEventValueChanged

diff --git a/...eact-native/React/Fabric/Mounting/ComponentViews/ScrollView/RCTScrollViewComponentView.mm b/...eact-native/React/Fabric/Mounting/ComponentViews/ScrollView/RCTScrollViewComponentView.mm
@@ -430,6 +430,8 @@ - (void)prepareForRecycle
   [super prepareForRecycle];
 }
 
+RCTComponentViewShouldBeRecycled(true);
+
 #pragma mark - UIScrollViewDelegate
 
 - (BOOL)touchesShouldCancelInContentView:(__unused UIView *)view

diff --git a/packages/react-native/React/Fabric/Mounting/ComponentViews/Switch/RCTSwitchComponentView.mm b/packages/react-native/React/Fabric/Mounting/ComponentViews/Switch/RCTSwitchComponentView.mm
@@ -100,6 +100,8 @@ - (void)onChange:(UISwitch *)sender
       .onChange(SwitchEventEmitter::OnChange{.value = static_cast<bool>(sender.on)});
 }
 
+RCTComponentViewShouldBeRecycled(true);
+
 #pragma mark - Native Commands
 
 - (void)handleCommand:(const NSString *)commandName args:(const NSArray *)args

diff --git a/packages/react-native/React/Fabric/Mounting/ComponentViews/Text/RCTParagraphComponentView.mm b/packages/react-native/React/Fabric/Mounting/ComponentViews/Text/RCTParagraphComponentView.mm
@@ -115,6 +115,8 @@ - (void)prepareForRecycle
   _accessibilityProvider = nil;
 }
 
+RCTComponentViewShouldBeRecycled(true);
+
 - (void)drawRect:(CGRect)rect
 {
   if (!_state) {

diff --git a/.../react-native/React/Fabric/Mounting/ComponentViews/TextInput/RCTTextInputComponentView.mm b/.../react-native/React/Fabric/Mounting/ComponentViews/TextInput/RCTTextInputComponentView.mm
@@ -265,6 +265,8 @@ - (void)prepareForRecycle
   [_backedTextInputView resignFirstResponder];
 }
 
+RCTComponentViewShouldBeRecycled(true);
+
 #pragma mark - RCTBackedTextInputDelegate
 
 - (BOOL)textInputShouldBeginEditing

diff --git a/...ric/Mounting/ComponentViews/UnimplementedComponent/RCTUnimplementedNativeComponentView.mm b/...ric/Mounting/ComponentViews/UnimplementedComponent/RCTUnimplementedNativeComponentView.mm
@@ -56,4 +56,6 @@ - (void)updateProps:(const Props::Shared &)props oldProps:(const Props::Shared &
   [super updateProps:props oldProps:oldProps];
 }
 
+RCTComponentViewShouldBeRecycled(true);
+
 @end
diff --git a/...act/Fabric/Mounting/ComponentViews/UnimplementedView/RCTUnimplementedViewComponentView.mm b/...act/Fabric/Mounting/ComponentViews/UnimplementedView/RCTUnimplementedViewComponentView.mm
@@ -64,6 +64,8 @@ - (void)updateProps:(const Props::Shared &)props oldProps:(const Props::Shared &
   [super updateProps:props oldProps:oldProps];
 }
 
+RCTComponentViewShouldBeRecycled(true);
+
 @end
 
 Class<RCTComponentViewProtocol> RCTUnimplementedNativeViewCls(void)

diff --git a/packages/react-native/React/Fabric/Mounting/ComponentViews/View/RCTViewComponentView.h b/packages/react-native/React/Fabric/Mounting/ComponentViews/View/RCTViewComponentView.h
@@ -19,6 +19,18 @@
 
 NS_ASSUME_NONNULL_BEGIN
 
+#define RCTComponentViewShouldBeRecycled(recycled)    \
+  static bool _shouldBeRecycled = recycled;           \
+  +(bool)shouldBeRecycled                             \
+  {                                                   \
+    return _shouldBeRecycled;                         \
+  }                                                   \
+                                                      \
+  +(void)setShouldBeRecycled : (bool)shouldBeRecycled \
+  {                                                   \
+    _shouldBeRecycled = shouldBeRecycled;             \
+  }
+
 /**
  * UIView class for <View> component.
  */

diff --git a/packages/react-native/React/Fabric/Mounting/ComponentViews/View/RCTViewComponentView.mm b/packages/react-native/React/Fabric/Mounting/ComponentViews/View/RCTViewComponentView.mm
@@ -100,6 +100,8 @@ - (void)traitCollectionDidChange:(UITraitCollection *)previousTraitCollection
   }
 }
 
+RCTComponentViewShouldBeRecycled(true);
+
 #pragma mark - RCTComponentViewProtocol
 
 + (ComponentDescriptorProvider)componentDescriptorProvider

diff --git a/packages/react-native/React/Fabric/Mounting/RCTComponentViewProtocol.h b/packages/react-native/React/Fabric/Mounting/RCTComponentViewProtocol.h
@@ -125,6 +125,11 @@ typedef NS_OPTIONS(NSInteger, RNComponentViewUpdateMask) {
 - (void)setPropKeysManagedByAnimated_DO_NOT_USE_THIS_IS_BROKEN:(nullable NSSet<NSString *> *)props;
 - (nullable NSSet<NSString *> *)propKeysManagedByAnimated_DO_NOT_USE_THIS_IS_BROKEN;
 
+/*
+ * Mark component view should be recycled.
+ */
++ (void)setShouldBeRecycled:(bool)shouldBeRecycled;
+
 @end
 
 NS_ASSUME_NONNULL_END
diff --git a/packages/react-native/React/Fabric/Mounting/UIView+ComponentViewProtocol.h b/packages/react-native/React/Fabric/Mounting/UIView+ComponentViewProtocol.h
@@ -46,6 +46,8 @@ NS_ASSUME_NONNULL_BEGIN
 
 - (void)updateClippedSubviewsWithClipRect:(CGRect)clipRect relativeToView:(UIView *)clipView;
 
++ (void)setShouldBeRecycled:(bool)shouldBeRecycled;
+
 @end
 
 NS_ASSUME_NONNULL_END
diff --git a/packages/react-native/React/Fabric/Mounting/UIView+ComponentViewProtocol.mm b/packages/react-native/React/Fabric/Mounting/UIView+ComponentViewProtocol.mm
@@ -168,4 +168,9 @@ - (void)updateClippedSubviewsWithClipRect:(CGRect)clipRect relativeToView:(UIVie
   }
 }
 
++ (void)setShouldBeRecycled:(bool)shouldBeRecycled
+{
+  // Default implementation does nothing.
+}
+
 @end
-Original file line number
+Diff line change
@@ Expand Up @@
       [super updateProps:props oldProps:oldProps];
     }
+    RCTComponentViewShouldBeRecycled(true);
     @end
     Class<RCTComponentViewProtocol> RCTActivityIndicatorViewCls(void)
@@ Expand Down @@