Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced print() with logger #94 #95

Merged
merged 1 commit into from
Apr 20, 2021

Conversation

itsabhianant
Copy link
Contributor

Closes #94

cc @zhiqwang

@CLAassistant
Copy link

CLAassistant commented Apr 20, 2021

CLA assistant check
All committers have signed the CLA.

@itsabhianant
Copy link
Contributor Author

Hi @zhiqwang ,

I have made the changes as per your instruction in the context of issue #94 .
Please feel free to let me know if any changes are needed to be made.

Best,
Abhishek

@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #95 (b515089) into master (0248f97) will increase coverage by 0.04%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
+ Coverage   83.35%   83.39%   +0.04%     
==========================================
  Files           8        8              
  Lines         775      777       +2     
==========================================
+ Hits          646      648       +2     
  Misses        129      129              
Flag Coverage Δ
unittests 83.39% <66.66%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/common_utils.py 53.38% <66.66%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0248f97...b515089. Read the comment docs.

Copy link
Owner

@zhiqwang zhiqwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zhiqwang
Copy link
Owner

Hi @itsabhianant . Thanks for your contributions and welcome for joining yolort 🤗!

@zhiqwang zhiqwang merged commit 999fcb2 into zhiqwang:master Apr 20, 2021
@zhiqwang zhiqwang added the enhancement New feature or request label Apr 20, 2021
@itsabhianant itsabhianant deleted the print-to-logger branch April 20, 2021 03:30
@itsabhianant
Copy link
Contributor Author

Hi @itsabhianant . Thanks for your contributions and welcome for joining yolort 🤗!

Thanks, @zhiqwang. I got to know about logging while working on this project so it was great working on this project 🤗🤗🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace print with logger
3 participants