Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support training with vanilla module #87

Merged
merged 4 commits into from
Apr 8, 2021
Merged

Support training with vanilla module #87

merged 4 commits into from
Apr 8, 2021

Conversation

zhiqwang
Copy link
Owner

@zhiqwang zhiqwang commented Apr 8, 2021

Closes #86

@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #87 (5495d7f) into master (c4d3962) will increase coverage by 1.33%.
The diff coverage is 96.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
+ Coverage   81.97%   83.31%   +1.33%     
==========================================
  Files           8        9       +1     
  Lines         738      797      +59     
==========================================
+ Hits          605      664      +59     
  Misses        133      133              
Flag Coverage Δ
unittests 83.31% <96.92%> (+1.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/test_torchscript.py 100.00% <ø> (+2.00%) ⬆️
test/test_engine.py 99.23% <96.77%> (+0.19%) ⬆️
test/test_data_pipeline.py 97.05% <97.05%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4d3962...5495d7f. Read the comment docs.

@zhiqwang zhiqwang merged commit 8597fa8 into master Apr 8, 2021
@zhiqwang zhiqwang deleted the issue-86 branch April 8, 2021 18:39
@zhiqwang zhiqwang added bug / fix Something isn't working and removed bugfix labels Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: string indices must be integers
1 participant