Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CONTRIBUTING.md #36

Merged
merged 1 commit into from
Jan 18, 2021
Merged

Create CONTRIBUTING.md #36

merged 1 commit into from
Jan 18, 2021

Conversation

BobinMathew
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jan 16, 2021

Codecov Report

Merging #36 (6488043) into master (d3a4bff) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #36   +/-   ##
=======================================
  Coverage   70.62%   70.62%           
=======================================
  Files           8        8           
  Lines         606      606           
=======================================
  Hits          428      428           
  Misses        178      178           
Flag Coverage Δ
unittests 70.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3a4bff...6488043. Read the comment docs.

Copy link
Owner

@zhiqwang zhiqwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @BobinMathew Also the CI running error is due to pytorch onnx updating, let's ignore it now.

I want to add more contributing guide like torchvision doing. Do you mind to enrich this current version.

@BobinMathew
Copy link
Contributor Author

I want to add more contributing guide like torchvision doing. Do you mind to enrich this current version.

I think the installation part should be specified on Readme.md files.

@zhiqwang
Copy link
Owner

I think the installation part should be specified on Readme.md files.

Hi @BobinMathew , I'm agree with you at this point. The contributing in torchvision is indeed a little complicated, Let's merge this PR first. And thanks for this PR!

@zhiqwang zhiqwang merged commit f4449f4 into zhiqwang:master Jan 18, 2021
@zhiqwang zhiqwang added the documentation Improvements or additions to documentation label Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants