Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docstrings for input type in YOLOTransform #308

Merged
merged 6 commits into from
Feb 12, 2022
Merged

Conversation

zhiqwang
Copy link
Owner

@zhiqwang zhiqwang commented Feb 10, 2022

cc @mattpopovich , Let the GH Actions tell us what happened there.

@zhiqwang zhiqwang added the code quality Code format and unit tests label Feb 10, 2022
Copy link
Owner Author

@zhiqwang zhiqwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mattpopovich ,

First check the test summary here:
https://github.com/zhiqwang/yolov5-rt-stack/runs/5139305768?check_suite_focus=true#step:11:1336

It is mainly used in two scenarios:

@mattpopovich
Copy link
Contributor

Brilliant! Thank you!

@zhiqwang zhiqwang closed this Feb 11, 2022
@zhiqwang zhiqwang deleted the test-transform branch February 11, 2022 00:59
@zhiqwang zhiqwang changed the title [NOMERGE] Test the input type in YOLOTransform Add docstrings for input type in YOLOTransform Feb 12, 2022
@zhiqwang zhiqwang restored the test-transform branch February 12, 2022 01:48
@zhiqwang zhiqwang reopened this Feb 12, 2022
@zhiqwang zhiqwang added the documentation Improvements or additions to documentation label Feb 12, 2022
@codecov
Copy link

codecov bot commented Feb 12, 2022

Codecov Report

Merging #308 (6a0d0b6) into main (c4fbbe1) will not change coverage.
The diff coverage is n/a.

❗ Current head 6a0d0b6 differs from pull request most recent head 1df9de8. Consider uploading reports for the commit 1df9de8 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #308   +/-   ##
=======================================
  Coverage   94.93%   94.93%           
=======================================
  Files          11       11           
  Lines         731      731           
=======================================
  Hits          694      694           
  Misses         37       37           
Flag Coverage Δ
unittests 94.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4fbbe1...1df9de8. Read the comment docs.

@zhiqwang zhiqwang merged commit de4c8e5 into main Feb 12, 2022
@zhiqwang zhiqwang deleted the test-transform branch February 12, 2022 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Code format and unit tests documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants