-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docstrings for input type in YOLOTransform
#308
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mattpopovich ,
First check the test summary here:
https://github.com/zhiqwang/yolov5-rt-stack/runs/5139305768?check_suite_focus=true#step:11:1336
It is mainly used in two scenarios:
-
For the dataloader in training and evaluation, the
images
will be a 4-dim Tensor in that case, and then this operation will bringimages
back to a list.
https://github.com/zhiqwang/yolov5-rt-stack/blob/720cd32334bb248ffdca5faf2f014fe04407bafa/yolort/data/_helper.py#L115 -
For
shape inference
when exporting ONNX models. The shape inference mechanism injit.trace
is a little weak, and seems that this line is essential to make it works.
Brilliant! Thank you! |
YOLOTransform
Codecov Report
@@ Coverage Diff @@
## main #308 +/- ##
=======================================
Coverage 94.93% 94.93%
=======================================
Files 11 11
Lines 731 731
=======================================
Hits 694 694
Misses 37 37
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
cc @mattpopovich , Let the GH Actions tell us what happened there.