Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove expired parameters in detect.py #263

Merged
merged 8 commits into from
Dec 30, 2021
Merged

Remove expired parameters in detect.py #263

merged 8 commits into from
Dec 30, 2021

Conversation

triple-Mu
Copy link
Contributor

@triple-Mu triple-Mu commented Dec 30, 2021 •
edited by zhiqwang
Loading

@CLAassistant
Copy link

CLAassistant commented Dec 30, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Dec 30, 2021 •
edited
Loading

Codecov Report

Merging #263 (5baad2f) into main (ac6ec43) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #263   +/-   ##
=======================================
  Coverage   93.62%   93.62%           
=======================================
  Files          11       11           
  Lines         675      675           
=======================================
  Hits          632      632           
  Misses         43       43
Flag Coverage Δ
unittests 93.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac6ec43...5baad2f. Read the comment docs.

zhiqwang
zhiqwang approved these changes Dec 30, 2021
View reviewed changes
Copy link
Owner

@zhiqwang zhiqwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @q3394101 , and welcome to yolort community!

@zhiqwang zhiqwang added the bug / fix Something isn't working label Dec 30, 2021
@zhiqwang zhiqwang changed the title There are some useless params in detect.py Remove expired parameters in detect.py Dec 30, 2021
@zhiqwang zhiqwang merged commit beed602 into zhiqwang:main Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhiqwang zhiqwang zhiqwang approved these changes

Assignees
No one assigned
Labels
bug / fix Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@triple-Mu @CLAassistant @zhiqwang