Revert SPPF to SPP
#240
Merged
Revert SPPF to SPP
#240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #240 +/- ##
=======================================
Coverage 93.49% 93.49%
=======================================
Files 10 10
Lines 661 661
=======================================
Hits 618 618
Misses 43 43
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
ShiquanYu
pushed a commit
to ShiquanYu/yolov5-rt-stack
that referenced
this pull request
Dec 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #234
I think the optimization of the
SPPmodule should be done in the downstream framework, and we should keep the parts of PyTorch simple, so let's revert theSPPFtoSPP.