Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more descriptive error logging #140

Merged
merged 2 commits into from
Jul 15, 2021
Merged

Added more descriptive error logging #140

merged 2 commits into from
Jul 15, 2021

Conversation

mattpopovich
Copy link
Contributor

I know I didn't open an issue before creating these changes, so feel free to discuss here in the PR.

Let me know your thoughts or if you'd like anything done differently!

@CLAassistant
Copy link

CLAassistant commented Jul 14, 2021

CLA assistant check
All committers have signed the CLA.

@zhiqwang zhiqwang added the documentation Improvements or additions to documentation label Jul 15, 2021
@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #140 (4504af5) into master (90e301f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #140   +/-   ##
=======================================
  Coverage   83.56%   83.56%           
=======================================
  Files           8        8           
  Lines         779      779           
=======================================
  Hits          651      651           
  Misses        128      128           
Flag Coverage Δ
unittests 83.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90e301f...4504af5. Read the comment docs.

Copy link
Owner

@zhiqwang zhiqwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @mattpopovich , this fix make sense to me, and thanks for your contributions here!

@zhiqwang zhiqwang merged commit 53a9d61 into zhiqwang:master Jul 15, 2021
@zhiqwang
Copy link
Owner

Hi @mattpopovich ,

Feel free to open a new PR if you have more thoughts about the libtorch deployment, the deployment in yolort is still in the early stages, we will put more energy into it in the future.

Welcome to join the yolort community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants