Address feedback from pull request Azure#3874 upstream github #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is better to check where ever these function are called in Dev or test code, we are changing there as well. |
|
I think, it will be better if we can load new package of any system and can run breakout with (-f -l) option, Just to make sure, nothing is broken there. |
|
kindly let me know if you have tested it on sonic box, we need to merge it here before MSFT. . Thx. |
praveen-li
approved these changes
Apr 24, 2020
praveen-li
pushed a commit
to praveen-li/sonic-buildimage
that referenced
this pull request
Aug 12, 2020
) **sonic-platform-common:** Commits on Jul 07, 2020 Changes in fan and psu base classes (1.0 platform API) related to pdd… 17292e4 Commits on Jul 10, 2020 update get_pcie_check() to use sysfs instead of lspci output (zhenggen-xu#95) d4eb804 Commits on Jul 11, 2020 [eeprom] Fix UnboundLocalError (zhenggen-xu#93) 7c8bed1 Commits on Jul 14, 2020 [Transceiver] Add parser for QSFP-DD cable type and dictionaries for … be1cc24 **sonic-platform-daemons:** Commits on Jul 06, 2020 [psud] Store PSU temperature and voltage information to database (zhenggen-xu#61) ef9716a Commits on Jul 14, 2020 [xcvrd] Add support for QSFP-DD cables (zhenggen-xu#66) c530587 Commits on Jul 18, 2020 Initial version of pcied (zhenggen-xu#60) e665ee8 [xcvrd] Return non-zero error code on SFP error (zhenggen-xu#67) 4f42a79 Commits on Jul 19, 2020 [README.md] Add LTGM badges (zhenggen-xu#69) 23757a3 Remove unused imports (zhenggen-xu#70) 029d5a5 Signed-off-by: Nazarii Hnydyn <[email protected]>
zhenggen-xu
pushed a commit
that referenced
this pull request
Aug 31, 2020
[configdb.py]: Allow deletion of entire table from mod_config API. (#61) [MultiDB] mimic redis-dump-load , adding sonic_db_dump_load.py and so… [MultiDB] add sonic-db-cli PING all instances support (#65) Fix sonic-db-cli script to be compatible with python3 and python2.7 (#66) Namespace support in SonicV2Connector (#63) [Multiasic]: Add calculation of interface index for backplane interfa…
praveen-li
pushed a commit
to praveen-li/sonic-buildimage
that referenced
this pull request
Feb 9, 2021
…on (sonic-net#3443) Submodule src/sonic-platform-common ac7fde6..58f9672: > [sfp_base] Raise exceptions (previously was incorrectly returning them) (zhenggen-xu#61) Submodule src/sonic-swss 660530e..2974844: > Fix MIRROR_SESSION table macro name (sonic-net#802) > Don't try to remove a vxlan tunnel if it has associated tunnel maps (sonic-net#1052) Submodule src/sonic-swss-common d6140fa..d7b1f53: > Fix MIRROR_SESSION table macro name (sonic-net#264) Signed-off-by: Ying Xie <[email protected]>
praveen-li
pushed a commit
to praveen-li/sonic-buildimage
that referenced
this pull request
Mar 4, 2021
- Adding instructions to build telemetry server/go client inside docker (zhenggen-xu#68) - Add RBAC, gNOI, API Versioning and Bulk Set operations. (zhenggen-xu#61) … - Support NonTLS option for testing purpose only. (zhenggen-xu#67) … - Oc gnmi examples (zhenggen-xu#62) …
praveen-li
pushed a commit
to praveen-li/sonic-buildimage
that referenced
this pull request
May 14, 2021
- Adding instructions to build telemetry server/go client inside docker (zhenggen-xu#68) - Add RBAC, gNOI, API Versioning and Bulk Set operations. (zhenggen-xu#61) … - Support NonTLS option for testing purpose only. (zhenggen-xu#67) … - Oc gnmi examples (zhenggen-xu#62) …
praveen-li
pushed a commit
to praveen-li/sonic-buildimage
that referenced
this pull request
Aug 9, 2022
[master][sonic-linkmgrd] submodule updates df51322 Longxiang Lyu Fri May 6 10:01:46 2022 +0800 Add `ActiveActiveStateMachine` implementation (zhenggen-xu#64) e721ceb Jing Zhang Wed May 4 10:07:14 2022 -0700 Add doc for default route related changes (zhenggen-xu#63) 7bb06fb Jing Zhang Tue May 3 09:48:28 2022 -0700 Add Cli support to enable or disable default route related feature (zhenggen-xu#68) e4b02cb Jing Zhang Mon May 2 13:27:54 2022 -0700 Reset WaitActiveUp count before switching to active (zhenggen-xu#70) 212d960 Jing Zhang Wed Apr 27 10:35:05 2022 -0700 lower log level to warning (zhenggen-xu#69) 48abc9e Jing Zhang Thu Apr 14 16:50:04 2022 -0700 Add support to enable switchover time measurement (with link prober interval decreased to 10ms) feature (zhenggen-xu#61) c4858a6 Jing Zhang Thu Apr 14 11:27:55 2022 -0700 Avoid proactively switching to `active` if default route is missing (zhenggen-xu#62) sign-off: Jing Zhang [email protected]
praveen-li
pushed a commit
to praveen-li/sonic-buildimage
that referenced
this pull request
Aug 22, 2022
24f505148 [eloop.c]: Increase timeout of signal termination (zhenggen-xu#62) 2b2c1ad72 [driver_macsec_sonic.c]: Fixbug: a wrong db_wait in delete sa (zhenggen-xu#61) Signed-off-by: Ze Gan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
Port the changes for pull request Azure#3874 from upstream Azure master branch.
- How to verify it
build the sonic-yang-mgmt python package and run pytests
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)