fix: eslint issues (apache#198)

zhaoyongjie · Nov 24, 2021 · 4815725 · 4815725
1 parent 0e0b990
commit 4815725
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 2 deletions.
diff --git a/...perset_ui/superset-ui/packages/superset-ui-chart-composition/src/tooltip/TooltipTable.tsx b/...perset_ui/superset-ui/packages/superset-ui-chart-composition/src/tooltip/TooltipTable.tsx
@@ -29,7 +29,7 @@ export default class TooltipTable extends PureComponent<Props, {}> {
     return (
       <table className={className}>
         <tbody>
-          {data.map(({ key, keyColumn, keyStyle, valueColumn, valueStyle }, i) => (
+          {data.map(({ key, keyColumn, keyStyle, valueColumn, valueStyle }) => (
             <tr key={key}>
               <td style={keyStyle}>{keyColumn || key}</td>
               <td style={valueStyle ? { ...VALUE_CELL_STYLE, ...valueStyle } : VALUE_CELL_STYLE}>

diff --git a/...frontend/temporary_superset_ui/superset-ui/packages/superset-ui-chart/src/types/Column.ts b/...frontend/temporary_superset_ui/superset-ui/packages/superset-ui-chart/src/types/Column.ts
@@ -1,4 +1,5 @@
 /* eslint-disable no-unused-vars */
+/* eslint-disable import/prefer-default-export */
 
 export enum ColumnType {
   DOUBLE = 'DOUBLE',

diff --git a/...tend/temporary_superset_ui/superset-ui/packages/superset-ui-chart/src/types/Datasource.ts b/...tend/temporary_superset_ui/superset-ui/packages/superset-ui-chart/src/types/Datasource.ts
@@ -1,3 +1,5 @@
+/* eslint-disable import/prefer-default-export */
+
 import { Column } from './Column';
 import { QueryObjectMetric } from './Query';
 

diff --git a/...frontend/temporary_superset_ui/superset-ui/packages/superset-ui-chart/src/types/Metric.ts b/...frontend/temporary_superset_ui/superset-ui/packages/superset-ui-chart/src/types/Metric.ts
@@ -1,4 +1,5 @@
 /* eslint-disable no-unused-vars */
+/* eslint-disable import/prefer-default-export */
 
 import { Column } from './Column';
 

diff --git a/...orary_superset_ui/superset-ui/packages/superset-ui-chart/test/clients/ChartClient.test.ts b/...orary_superset_ui/superset-ui/packages/superset-ui-chart/test/clients/ChartClient.test.ts
@@ -170,7 +170,8 @@ describe('ChartClient', () => {
         field1: 'abc',
         field2: 'def',
       });
-      expect(chartClient.loadDatasource('1__table')).resolves.toEqual({
+
+      return expect(chartClient.loadDatasource('1__table')).resolves.toEqual({
         field1: 'abc',
         field2: 'def',
       });