chore: fix end-of-file (apache#1468)

* chore: end of file fixer * compress image * lint without build * lintrc improvment * exporting * update parallel-coordinates tsconfig * add license to md file * add license * add eslintignore
zhaoyongjie · Nov 25, 2021 · 062c4b0 · 062c4b0
1 parent c3f1fbb
commit 062c4b0
Show file tree

Hide file tree

Showing 128 changed files with 1,437 additions and 61 deletions.
diff --git a/superset-frontend/temporary_superset_ui/superset-ui/.eslintignore b/superset-frontend/temporary_superset_ui/superset-ui/.eslintignore
@@ -5,4 +5,5 @@ esm/
 lib/
 tmp/
 dist/
-temporary-plugins/
+temporary-plugins/
+storybook-static/
diff --git a/superset-frontend/temporary_superset_ui/superset-ui/.eslintrc.js b/superset-frontend/temporary_superset_ui/superset-ui/.eslintrc.js
@@ -39,6 +39,38 @@ module.exports = {
         extensions: ['.js', '.jsx', '.ts', '.tsx'],
       },
     },
+    // Allow core/src and core/test, not import modules from lib
+    'import/internal-regex': /^@superset-ui\/core\/(src|test)/,
+    'import/core-modules': [
+      '@superset-ui/core',
+      '@superset-ui/chart-controls',
+      '@superset-ui/legacy-plugin-chart-calendar',
+      '@superset-ui/legacy-plugin-chart-chord',
+      '@superset-ui/legacy-plugin-chart-country-map',
+      '@superset-ui/legacy-plugin-chart-event-flow',
+      '@superset-ui/legacy-plugin-chart-force-directed',
+      '@superset-ui/legacy-plugin-chart-heatmap',
+      '@superset-ui/legacy-plugin-chart-histogram',
+      '@superset-ui/legacy-plugin-chart-horizon',
+      '@superset-ui/legacy-plugin-chart-map-box',
+      '@superset-ui/legacy-plugin-chart-paired-t-test',
+      '@superset-ui/legacy-plugin-chart-parallel-coordinates',
+      '@superset-ui/legacy-plugin-chart-partition',
+      '@superset-ui/legacy-plugin-chart-pivot-table',
+      '@superset-ui/legacy-plugin-chart-rose',
+      '@superset-ui/legacy-plugin-chart-sankey',
+      '@superset-ui/legacy-plugin-chart-sankey-loop',
+      '@superset-ui/legacy-plugin-chart-sunburst',
+      '@superset-ui/legacy-plugin-chart-time-table',
+      '@superset-ui/legacy-plugin-chart-treemap',
+      '@superset-ui/legacy-plugin-chart-world-map',
+      '@superset-ui/legacy-preset-chart-big-number',
+      '@superset-ui/legacy-preset-chart-nvd3',
+      '@superset-ui/plugin-chart-echarts',
+      '@superset-ui/plugin-chart-table',
+      '@superset-ui/plugin-chart-word-cloud',
+      '@superset-ui/preset-chart-xy',
+    ],
     react: {
       version: 'detect',
     },
@@ -215,7 +247,13 @@ module.exports = {
       },
     },
     {
-      files: ['*.test.*', './**/test/**/*'],
+      files: [
+        '*.test.ts',
+        '*.test.tsx',
+        '*.test.js',
+        '*.test.jsx',
+        'fixtures.*',
+      ],
       plugins: ['jest', 'jest-dom', 'no-only-tests', 'testing-library'],
       env: {
         'jest/globals': true,

diff --git a/superset-frontend/temporary_superset_ui/superset-ui/.github/workflows/ci.yml b/superset-frontend/temporary_superset_ui/superset-ui/.github/workflows/ci.yml
@@ -52,10 +52,10 @@ jobs:
 
       - name: Install dependencies
         run: npm ci
-      - name: Build packages
-        run: npm run build
       - name: Run ESLint
         run: npm run lint --quiet
+      - name: Build packages
+        run: npm run build
       - name: Run unit tests
         run: npm run test
       - name: Build Storybook

diff --git a/superset-frontend/temporary_superset_ui/superset-ui/LICENSE b/superset-frontend/temporary_superset_ui/superset-ui/LICENSE
@@ -198,4 +198,4 @@ Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,
 WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 See the License for the specific language governing permissions and
-limitations under the License.
+limitations under the License.
diff --git a/superset-frontend/temporary_superset_ui/superset-ui/package.json b/superset-frontend/temporary_superset_ui/superset-ui/package.json
@@ -21,7 +21,7 @@
     "lint": "eslint --ignore-path=.eslintignore --ext .js,.jsx,.ts,.tsx .",
     "lint:fix": "eslint --fix --ignore-path=.eslintignore --ext .js,.jsx,.ts,.tsx .",
     "format": "npm run prettier",
-    "prettier": "prettier --write .",
+    "prettier": "prettier --write './{plugins,packages}/**/*{.js,.jsx,.ts,.tsx,.css,.less,.scss,.sass}'",
     "test": "npm run jest",
     "test:watch": "npm run lint:fix && npm run jest --watch",
     "type": "npm run build --no-babel",

diff --git a/...tend/temporary_superset_ui/superset-ui/packages/generator-superset/CHANGELOG.md b/...tend/temporary_superset_ui/superset-ui/packages/generator-superset/CHANGELOG.md
@@ -1,3 +1,22 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
 # Change Log
 
 All notable changes to this project will be documented in this file.

diff --git a/...rontend/temporary_superset_ui/superset-ui/packages/generator-superset/README.md b/...rontend/temporary_superset_ui/superset-ui/packages/generator-superset/README.md
@@ -1,3 +1,22 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
 # generator-superset
 
 [![Version](https://img.shields.io/npm/v/@superset-ui/generator-superset.svg?style=flat)](https://www.npmjs.com/package/@superset-ui/generator-superset)

diff --git a/.../superset-ui/packages/generator-superset/generators/package/templates/README.md b/.../superset-ui/packages/generator-superset/generators/package/templates/README.md
@@ -1,3 +1,22 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
 ## @superset-ui/<%= name %>
 
 [![Version](https://img.shields.io/npm/v/@superset-ui/<%= name

diff --git a/...t_ui/superset-ui/packages/generator-superset/generators/plugin-chart/templates/README.erb b/...t_ui/superset-ui/packages/generator-superset/generators/plugin-chart/templates/README.erb
@@ -51,4 +51,4 @@ Then use it via `SuperChart`. See [storybook](https://apache-superset.github.io/
 │   └── index.test.ts
 └── types
     └── external.d.ts
-```
+```
diff --git a/...frontend/temporary_superset_ui/superset-ui/packages/generator-superset/test/tsconfig.json b/...frontend/temporary_superset_ui/superset-ui/packages/generator-superset/test/tsconfig.json
@@ -16,4 +16,4 @@
       "path": ".."
     }
   ]
-}
+}
diff --git a/...porary_superset_ui/superset-ui/packages/superset-ui-chart-controls/CHANGELOG.md b/...porary_superset_ui/superset-ui/packages/superset-ui-chart-controls/CHANGELOG.md
@@ -1,3 +1,22 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
 # Change Log
 
 All notable changes to this project will be documented in this file.

diff --git a/...temporary_superset_ui/superset-ui/packages/superset-ui-chart-controls/README.md b/...temporary_superset_ui/superset-ui/packages/superset-ui-chart-controls/README.md
@@ -1,3 +1,22 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
 ## @superset-ui/chart-controls
 
 [![Version](https://img.shields.io/npm/v/@superset-ui/chart-controls.svg?style=flat)](https://www.npmjs.com/package/@superset-ui/chart-controls)

diff --git a/...ontend/temporary_superset_ui/superset-ui/packages/superset-ui-chart-controls/src/types.ts b/...ontend/temporary_superset_ui/superset-ui/packages/superset-ui-chart-controls/src/types.ts
@@ -177,7 +177,7 @@ export type TabOverride = 'data' | 'customize' | boolean;
  *    show a warning based on the value of another component. It's also possible to bind
  *    arbitrary data from the redux store to the component this way.
  * - tabOverride: set to 'data' if you want to force a renderTrigger to show up on the `Data`
-     tab, or 'customize' if you want it to show up on that tam. Otherwise sections with ALL 
+     tab, or 'customize' if you want it to show up on that tam. Otherwise sections with ALL
      `renderTrigger: true` components will show up on the `Customize` tab.
  * - visibility: a function that uses control panel props to check whether a control should
  *    be visibile.

diff --git a/.../temporary_superset_ui/superset-ui/packages/superset-ui-chart-controls/test/tsconfig.json b/.../temporary_superset_ui/superset-ui/packages/superset-ui-chart-controls/test/tsconfig.json
@@ -16,4 +16,4 @@
       "path": ".."
     }
   ]
-}
+}
diff --git a/.../temporary_superset_ui/superset-ui/packages/superset-ui-chart-controls/test/types.test.ts b/.../temporary_superset_ui/superset-ui/packages/superset-ui-chart-controls/test/types.test.ts
@@ -17,8 +17,12 @@
  * under the License.
  */
 import { AdhocColumn } from '@superset-ui/core';
-import { isAdhocColumn, isColumnMeta, isSavedExpression } from '../src';
-import { ColumnMeta } from '../lib';
+import {
+  isAdhocColumn,
+  isColumnMeta,
+  isSavedExpression,
+  ColumnMeta,
+} from '../src';
 
 const ADHOC_COLUMN: AdhocColumn = {
   hasCustomLabel: true,

diff --git a/...ntend/temporary_superset_ui/superset-ui/packages/superset-ui-chart-controls/tsconfig.json b/...ntend/temporary_superset_ui/superset-ui/packages/superset-ui-chart-controls/tsconfig.json
@@ -19,4 +19,4 @@
       "path": "../superset-ui-core"
     }
   ]
-}
+}
diff --git a/...ontend/temporary_superset_ui/superset-ui/packages/superset-ui-core/CHANGELOG.md b/...ontend/temporary_superset_ui/superset-ui/packages/superset-ui-core/CHANGELOG.md
@@ -1,3 +1,22 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
 # Change Log
 
 All notable changes to this project will be documented in this file.

diff --git a/...-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-core/README.md b/...-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-core/README.md
@@ -1,3 +1,22 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
 ## @superset-ui/core
 
 [![Version](https://img.shields.io/npm/v/@superset-ui/core.svg?style=flat)](https://www.npmjs.com/package/@superset-ui/core)

diff --git a/...rary_superset_ui/superset-ui/packages/superset-ui-core/src/connection/README.md b/...rary_superset_ui/superset-ui/packages/superset-ui-core/src/connection/README.md
@@ -1,3 +1,22 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
 ## @superset-ui/core/connection
 
 Connection modules for Superset:

diff --git a/...y_superset_ui/superset-ui/packages/superset-ui-core/src/number-format/README.md b/...y_superset_ui/superset-ui/packages/superset-ui-core/src/number-format/README.md
@@ -1,3 +1,22 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
 ## @superset-ui/core/number-format
 
 Description

diff --git a/...temporary_superset_ui/superset-ui/packages/superset-ui-core/src/query/README.md b/...temporary_superset_ui/superset-ui/packages/superset-ui-core/src/query/README.md
@@ -1,3 +1,22 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
 ## @superset-ui/core/query
 
 Utility to make API requests to Superset backend.

diff --git a/...d/temporary_superset_ui/superset-ui/packages/superset-ui-core/src/query/getColumnLabel.ts b/...d/temporary_superset_ui/superset-ui/packages/superset-ui-core/src/query/getColumnLabel.ts
@@ -1,3 +1,22 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
 import { isPhysicalColumn, QueryFormColumn } from './types';
 
 export default function getColumnLabel(column: QueryFormColumn): string {